diff mbox

Fix pasto in lto-partition.c

Message ID 20160118155930.GA31142@kam.mff.cuni.cz
State New
Headers show

Commit Message

Jan Hubicka Jan. 18, 2016, 3:59 p.m. UTC 
Hi,
this patch fixes pasto that leads to undefined symbol in the testcase in PR69003.
Unfortunately i am not sure how to  do incremental linking tests in the testsuite.
The patch should work for the release branches, too,

Honza

Comments

Richard Biener Jan. 18, 2016, 4:37 p.m. UTC | #1 
On January 18, 2016 4:59:30 PM GMT+01:00, Jan Hubicka <hubicka@ucw.cz> wrote:
>Hi,
>this patch fixes pasto that leads to undefined symbol in the testcase
>in PR69003.
>Unfortunately i am not sure how to  do incremental linking tests in the
>testsuite.

Only with custom .exp files I guess.

>The patch should work for the release branches, too,

Can you back port it then please?

Richard.

>Honza
>
>Index: ChangeLog
>===================================================================
>--- ChangeLog	(revision 232466)
>+++ ChangeLog	(working copy)
>@@ -1,3 +1,8 @@
>+2016-01-12  Jan Hubicka  <hubicka@ucw.cz>
>+
>+	PR lto/69003
>+	* lto-partition.c (rename_statics): Fix pasto.
>+
> 2016-01-12  Richard Biener  <rguenther@suse.de>
> 
> 	PR lto/69077
>Index: lto-partition.c
>===================================================================
>--- lto-partition.c	(revision 232466)
>+++ lto-partition.c	(working copy)
>@@ -1077,8 +1077,8 @@ rename_statics (lto_symtab_encoder_t enc
> 		  IDENTIFIER_POINTER
> 		    (DECL_ASSEMBLER_NAME (s->get_alias_target()->decl))))
> 	&& ((s->real_symbol_p ()
>-             && !DECL_EXTERNAL (node->decl)
>-	     && !TREE_PUBLIC (node->decl))
>+             && !DECL_EXTERNAL (s->decl)
>+	     && !TREE_PUBLIC (s->decl))
>  	    || may_need_named_section_p (encoder, s))
> 	&& (!encoder
> 	    || lto_symtab_encoder_lookup (encoder, s) != LCC_NOT_FOUND))
diff mbox

Patch

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 232466)
+++ ChangeLog	(working copy)
@@ -1,3 +1,8 @@ 
+2016-01-12  Jan Hubicka  <hubicka@ucw.cz>
+
+	PR lto/69003
+	* lto-partition.c (rename_statics): Fix pasto.
+
 2016-01-12  Richard Biener  <rguenther@suse.de>
 
 	PR lto/69077
Index: lto-partition.c
===================================================================
--- lto-partition.c	(revision 232466)
+++ lto-partition.c	(working copy)
@@ -1077,8 +1077,8 @@  rename_statics (lto_symtab_encoder_t enc
 		  IDENTIFIER_POINTER
 		    (DECL_ASSEMBLER_NAME (s->get_alias_target()->decl))))
 	&& ((s->real_symbol_p ()
-             && !DECL_EXTERNAL (node->decl)
-	     && !TREE_PUBLIC (node->decl))
+             && !DECL_EXTERNAL (s->decl)
+	     && !TREE_PUBLIC (s->decl))
  	    || may_need_named_section_p (encoder, s))
 	&& (!encoder
 	    || lto_symtab_encoder_lookup (encoder, s) != LCC_NOT_FOUND))