Patchwork [07/12] blockdev: drive_get_by_id() is no longer used, remove

login
register
mail settings
Submitter Markus Armbruster
Date June 25, 2010, 4:53 p.m.
Message ID <1277484812-22012-8-git-send-email-armbru@redhat.com>
Download mbox | patch
Permalink /patch/56955/
State New
Headers show

Comments

Markus Armbruster - June 25, 2010, 4:53 p.m.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 blockdev.c |   12 ------------
 blockdev.h |    1 -
 2 files changed, 0 insertions(+), 13 deletions(-)
Christoph Hellwig - June 26, 2010, 10:09 a.m.
Looks good,


Reviewed-by: Christoph Hellwig <hch@lst.de>

Patch

diff --git a/blockdev.c b/blockdev.c
index 827ea1c..3747098 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -75,18 +75,6 @@  DriveInfo *drive_get(BlockInterfaceType type, int bus, int unit)
     return NULL;
 }
 
-DriveInfo *drive_get_by_id(const char *id)
-{
-    DriveInfo *dinfo;
-
-    QTAILQ_FOREACH(dinfo, &drives, next) {
-        if (strcmp(id, dinfo->id))
-            continue;
-        return dinfo;
-    }
-    return NULL;
-}
-
 int drive_get_max_bus(BlockInterfaceType type)
 {
     int max_bus;
diff --git a/blockdev.h b/blockdev.h
index 418ebb6..a72d335 100644
--- a/blockdev.h
+++ b/blockdev.h
@@ -41,7 +41,6 @@  typedef struct DriveInfo {
 #define MAX_SCSI_DEVS	7
 
 extern DriveInfo *drive_get(BlockInterfaceType type, int bus, int unit);
-extern DriveInfo *drive_get_by_id(const char *id);
 extern int drive_get_max_bus(BlockInterfaceType type);
 extern void drive_uninit(DriveInfo *dinfo);
 extern DriveInfo *drive_of_blockdev(BlockDriverState *bs);