diff mbox

[1/1] package/uboot-tools: bump to version 2016.01

Message ID 1452980355-20322-1-git-send-email-joerg.krause@embedded.rocks
State Accepted
Commit 29a570fbc9de58d6a48e1a32a06d1e9d5290fc90
Headers show

Commit Message

Jörg Krause Jan. 16, 2016, 9:39 p.m. UTC
Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
---
 package/uboot-tools/uboot-tools.hash | 2 +-
 package/uboot-tools/uboot-tools.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Arnout Vandecappelle Jan. 16, 2016, 9:51 p.m. UTC | #1
On 16-01-16 22:39, Jörg Krause wrote:
> Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>

 Maybe add

Fixes
http://autobuild.buildroot.net/results/9ebc5e3a6f1dd3ceb90d6786a1c5455c965f819e


> ---
>  package/uboot-tools/uboot-tools.hash | 2 +-
>  package/uboot-tools/uboot-tools.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/uboot-tools/uboot-tools.hash b/package/uboot-tools/uboot-tools.hash
> index 65a5261..31b0db9 100644
> --- a/package/uboot-tools/uboot-tools.hash
> +++ b/package/uboot-tools/uboot-tools.hash
> @@ -1,2 +1,2 @@
>  # Locally computed:
> -sha256	bdc68d5f9455ad933b059c735d983f2c8b6b552dafb062e5ff1444f623021955  u-boot-2015.10.tar.bz2
> +sha256  e5792fba9399d9804aa2ef667f14ff771e2cdece72367d340250265bf095a5d5  u-boot-2016.01.tar.bz2

 Don't we normally separate with tabs?

 Regards,
 Arnout

> diff --git a/package/uboot-tools/uboot-tools.mk b/package/uboot-tools/uboot-tools.mk
> index 6e4d0ed..3150279 100644
> --- a/package/uboot-tools/uboot-tools.mk
> +++ b/package/uboot-tools/uboot-tools.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -UBOOT_TOOLS_VERSION = 2015.10
> +UBOOT_TOOLS_VERSION = 2016.01
>  UBOOT_TOOLS_SOURCE = u-boot-$(UBOOT_TOOLS_VERSION).tar.bz2
>  UBOOT_TOOLS_SITE = ftp://ftp.denx.de/pub/u-boot
>  UBOOT_TOOLS_LICENSE = GPLv2+
>
Yann E. MORIN Jan. 16, 2016, 10:49 p.m. UTC | #2
Arnout, All,

On 2016-01-16 22:51 +0100, Arnout Vandecappelle spake thusly:
> On 16-01-16 22:39, Jörg Krause wrote:
> > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
> 
>  Maybe add
> 
> Fixes
> http://autobuild.buildroot.net/results/9ebc5e3a6f1dd3ceb90d6786a1c5455c965f819e
> 
> 
> > ---
> >  package/uboot-tools/uboot-tools.hash | 2 +-
> >  package/uboot-tools/uboot-tools.mk   | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/package/uboot-tools/uboot-tools.hash b/package/uboot-tools/uboot-tools.hash
> > index 65a5261..31b0db9 100644
> > --- a/package/uboot-tools/uboot-tools.hash
> > +++ b/package/uboot-tools/uboot-tools.hash
> > @@ -1,2 +1,2 @@
> >  # Locally computed:
> > -sha256	bdc68d5f9455ad933b059c735d983f2c8b6b552dafb062e5ff1444f623021955  u-boot-2015.10.tar.bz2
> > +sha256  e5792fba9399d9804aa2ef667f14ff771e2cdece72367d340250265bf095a5d5  u-boot-2016.01.tar.bz2
> 
>  Don't we normally separate with tabs?

Well, when I added support for hashes, I intended it to be used with
spaces, a bit like the output of the corresponding *sum utilities, so
that it could be esaily copy-pasted to create a .hash file.

Also, the manual states:

    The format of this file is one line for each file for which to check
    the hash, each line being space-separated, with these three fields:
    [...]
    The number of spaces does not matter, so one can use spaces (or
    tabs) to properly align the different fields.

So, to me, TABs are accepted, but spaces should be the norm.

At least, I despise TABs... ;-] They are whatever the user wants them
to be, and thus break any alignment that was done by the author of the
code. I believe TABs should be proscribed everywhere it's possible
(Makefiles being the outstanding offenders^Wexception...).

Regards,
Yann E. MORIN.
Arnout Vandecappelle Jan. 17, 2016, 8:13 p.m. UTC | #3
On 16-01-16 23:49, Yann E. MORIN wrote:
> Arnout, All,
> 
> On 2016-01-16 22:51 +0100, Arnout Vandecappelle spake thusly:
>> On 16-01-16 22:39, Jörg Krause wrote:
>>> Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
>>
>>  Maybe add
>>
>> Fixes
>> http://autobuild.buildroot.net/results/9ebc5e3a6f1dd3ceb90d6786a1c5455c965f819e
>>
>>
>>> ---
>>>  package/uboot-tools/uboot-tools.hash | 2 +-
>>>  package/uboot-tools/uboot-tools.mk   | 2 +-
>>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/package/uboot-tools/uboot-tools.hash b/package/uboot-tools/uboot-tools.hash
>>> index 65a5261..31b0db9 100644
>>> --- a/package/uboot-tools/uboot-tools.hash
>>> +++ b/package/uboot-tools/uboot-tools.hash
>>> @@ -1,2 +1,2 @@
>>>  # Locally computed:
>>> -sha256	bdc68d5f9455ad933b059c735d983f2c8b6b552dafb062e5ff1444f623021955  u-boot-2015.10.tar.bz2
>>> +sha256  e5792fba9399d9804aa2ef667f14ff771e2cdece72367d340250265bf095a5d5  u-boot-2016.01.tar.bz2
>>
>>  Don't we normally separate with tabs?
> 
> Well, when I added support for hashes, I intended it to be used with
> spaces, a bit like the output of the corresponding *sum utilities, so
> that it could be esaily copy-pasted to create a .hash file.
> 
> Also, the manual states:
> 
>     The format of this file is one line for each file for which to check
>     the hash, each line being space-separated, with these three fields:
>     [...]
>     The number of spaces does not matter, so one can use spaces (or
>     tabs) to properly align the different fields.
> 
> So, to me, TABs are accepted, but spaces should be the norm.

 Sounds like a plan to me. But then perhaps we should document that, because
right now we have 1051 lines in hash files with tabs, and only 895 with spaces
(and 1815 total so we also have a lot with mixed spaces-tabs...)

 To be compatible with sha256 output, I propose we should prescribe 2 spaces.

> 
> At least, I despise TABs... ;-] They are whatever the user wants them
> to be, and thus break any alignment that was done by the author of the
> code. I believe TABs should be proscribed everywhere it's possible
                                 ^^^^^^^^^^
 It rarely happens that I still learn a new English word... Funny that proscribe
and prescribe are almost opposites.

 Regards,
 Arnout

> (Makefiles being the outstanding offenders^Wexception...).
> 
> Regards,
> Yann E. MORIN.
>
Peter Korsgaard Jan. 17, 2016, 10:01 p.m. UTC | #4
>>>>> "Jörg" == Jörg Krause <joerg.krause@embedded.rocks> writes:

 > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>

Committed, thanks.
diff mbox

Patch

diff --git a/package/uboot-tools/uboot-tools.hash b/package/uboot-tools/uboot-tools.hash
index 65a5261..31b0db9 100644
--- a/package/uboot-tools/uboot-tools.hash
+++ b/package/uboot-tools/uboot-tools.hash
@@ -1,2 +1,2 @@ 
 # Locally computed:
-sha256	bdc68d5f9455ad933b059c735d983f2c8b6b552dafb062e5ff1444f623021955  u-boot-2015.10.tar.bz2
+sha256  e5792fba9399d9804aa2ef667f14ff771e2cdece72367d340250265bf095a5d5  u-boot-2016.01.tar.bz2
diff --git a/package/uboot-tools/uboot-tools.mk b/package/uboot-tools/uboot-tools.mk
index 6e4d0ed..3150279 100644
--- a/package/uboot-tools/uboot-tools.mk
+++ b/package/uboot-tools/uboot-tools.mk
@@ -4,7 +4,7 @@ 
 #
 ################################################################################
 
-UBOOT_TOOLS_VERSION = 2015.10
+UBOOT_TOOLS_VERSION = 2016.01
 UBOOT_TOOLS_SOURCE = u-boot-$(UBOOT_TOOLS_VERSION).tar.bz2
 UBOOT_TOOLS_SITE = ftp://ftp.denx.de/pub/u-boot
 UBOOT_TOOLS_LICENSE = GPLv2+