diff mbox

[v3] netsniff-ng: check if linux-headers are v3.0 or higher

Message ID 1452870220-1045-1-git-send-email-joris.lijssens@gmail.com
State Accepted
Headers show

Commit Message

Joris Lijssens Jan. 15, 2016, 3:03 p.m. UTC
netsniff-ng uses the TP_STATUS_VLAN_VALID define, provided by the
kernel headers. This definition has been added in the kernel by commit
a3bcc23e890a6d49d6763d9eb073d711de2e0469 ("af-packet: Add flag to
distinguish VID 0 from no-vlan"), which was merged in v3.0.

Fixes:
http://autobuild.buildroot.net/results/c87/c87a440e29ae387f600cb6ecce3caaa08557f4f0/

Signed-off-by: Joris Lijssens <joris.lijssens@gmail.com>
---
 package/netsniff-ng/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Thomas Petazzoni Jan. 16, 2016, 12:54 p.m. UTC | #1
Dear Joris Lijssens,

On Fri, 15 Jan 2016 16:03:40 +0100, Joris Lijssens wrote:
> netsniff-ng uses the TP_STATUS_VLAN_VALID define, provided by the
> kernel headers. This definition has been added in the kernel by commit
> a3bcc23e890a6d49d6763d9eb073d711de2e0469 ("af-packet: Add flag to
> distinguish VID 0 from no-vlan"), which was merged in v3.0.
> 
> Fixes:
> http://autobuild.buildroot.net/results/c87/c87a440e29ae387f600cb6ecce3caaa08557f4f0/
> 
> Signed-off-by: Joris Lijssens <joris.lijssens@gmail.com>
> ---
>  package/netsniff-ng/Config.in | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Applied, thanks.

Thomas
diff mbox

Patch

diff --git a/package/netsniff-ng/Config.in b/package/netsniff-ng/Config.in
index b39ec96..a2494a9 100644
--- a/package/netsniff-ng/Config.in
+++ b/package/netsniff-ng/Config.in
@@ -9,6 +9,7 @@  config BR2_PACKAGE_NETSNIFF_NG
 	# Build with uClibc fails due to missing ceill()
 	# Build with musl fails due to various header issues
 	depends on BR2_TOOLCHAIN_USES_GLIBC
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu
 	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
@@ -17,9 +18,10 @@  config BR2_PACKAGE_NETSNIFF_NG
 	  networking toolkit. If you will, the Swiss army knife for
 	  network packets.
 
-comment "netsniff-ng needs an (e)glibc toolchain w/ threads"
+comment "netsniff-ng needs an (e)glibc toolchain w/ threads, headers >= 3.0"
 	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_USES_GLIBC
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_USES_GLIBC \
+		|| !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854
 
 comment "netsniff-ng needs a toolchain not affected by GCC bug 58854"