Patchwork [wwwdocs] Generated files and patches

login
register
mail settings
Submitter Sebastian Huber
Date June 24, 2010, 11:32 a.m.
Message ID <4C234257.5060006@embedded-brains.de>
Download mbox | patch
Permalink /patch/56782/
State New
Headers show

Comments

Sebastian Huber - June 24, 2010, 11:32 a.m.
Hi,

someone told me that generated files should be not included in patches.  It
would be nice if this is mentioned at

http://gcc.gnu.org/contribute.html

Who writes the ChangeLog for the generated files?

Have a nice day!
Manuel López-Ibáñez - June 24, 2010, 11:46 a.m.
On 24 June 2010 13:32, Sebastian Huber
<sebastian.huber@embedded-brains.de> wrote:
> Hi,
>
> someone told me that generated files should be not included in patches.  It
> would be nice if this is mentioned at
>
> http://gcc.gnu.org/contribute.html
>
> Who writes the ChangeLog for the generated files?
>

I would say that the original submitter should just write:

 * configure.in: Regenerate.

even if the patch does not contain that part.

Do you have write-access to the SVN?

Cheers,

Manuel.

Patch

Index: htdocs/contribute.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/contribute.html,v
retrieving revision 1.73
diff -u -r1.73 contribute.html
--- htdocs/contribute.html	4 Aug 2009 05:37:10 -0000	1.73
+++ htdocs/contribute.html	24 Jun 2010 11:30:51 -0000
@@ -235,7 +235,10 @@ 
 If your version of diff does not support these options, then get the 
 latest version of GNU diff.  Patches against current development (SVN trunk) 
 are preferred to patches against releases, unless your patch is intended
-as a candidate for the release branch.
+as a candidate for the release branch.  The patch should not include generated
+files like <code>configure.in</code>, <code>Makefile.in</code>, etc.  The
+person who eventually commits the patch will take care of regenerating these
+files with the appropriate tool.
 </dd>
 
 </dl>