Patchwork powerpc/40x: Don't enable HCU4 board by default

login
register
mail settings
Submitter Josh Boyer
Date Oct. 24, 2008, 2:31 p.m.
Message ID <20081024143158.GA13766@yoda.jdub.homelinux.org>
Download mbox | patch
Permalink /patch/5678/
State Accepted, archived
Commit c8d7aa91bc38e2de5c74c48ba33b9c950c28ffac
Delegated to: Josh Boyer
Headers show

Comments

Josh Boyer - Oct. 24, 2008, 2:31 p.m.
Fix the HCU4 Kconfig option to 'default n'.  We don't want the
board to always be enabled for other board defconfigs.

Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>

---
Niklaus Giger - Oct. 24, 2008, 9:54 p.m.
Am Freitag 24 Oktober 2008 16.31:58 schrieb Josh Boyer:
> Fix the HCU4 Kconfig option to 'default n'.  We don't want the
> board to always be enabled for other board defconfigs.
Sorry, for this silly mistake. Thanks for your fix.

My board compiles and runs fine using Linus 2.6.28-rc1.

>
> Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
>
> ---
>
> diff --git a/arch/powerpc/platforms/40x/Kconfig
> b/arch/powerpc/platforms/40x/Kconfig index 6573027..14e027f 100644
> --- a/arch/powerpc/platforms/40x/Kconfig
> +++ b/arch/powerpc/platforms/40x/Kconfig
> @@ -35,7 +35,7 @@ config EP405
>  config HCU4
>  	bool "Hcu4"
>  	depends on 40x
> -	default y
> +	default n
>  	select 405GPR
>  	help
>  	  This option enables support for the Nestal Maschinen HCU4 board.
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
Best regards

Niklaus
Josh Boyer - Oct. 24, 2008, 11:48 p.m.
On Fri, 24 Oct 2008 23:54:24 +0200
Niklaus Giger <niklaus.giger@member.fsf.org> wrote:

> Am Freitag 24 Oktober 2008 16.31:58 schrieb Josh Boyer:
> > Fix the HCU4 Kconfig option to 'default n'.  We don't want the
> > board to always be enabled for other board defconfigs.
> Sorry, for this silly mistake. Thanks for your fix.

You don't need to apologize.  Have you noticed that I have "fixed" the
EMAC driver 3 times this merge window already, all for my own stupid
mistakes? :)

> My board compiles and runs fine using Linus 2.6.28-rc1.

Thanks for testing!

josh

Patch

diff --git a/arch/powerpc/platforms/40x/Kconfig b/arch/powerpc/platforms/40x/Kconfig
index 6573027..14e027f 100644
--- a/arch/powerpc/platforms/40x/Kconfig
+++ b/arch/powerpc/platforms/40x/Kconfig
@@ -35,7 +35,7 @@  config EP405
 config HCU4
 	bool "Hcu4"
 	depends on 40x
-	default y
+	default n
 	select 405GPR
 	help
 	  This option enables support for the Nestal Maschinen HCU4 board.