| Message ID | 1452782691-5193-1-git-send-email-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Accepted |
| Commit | 54ca3cd594db58d65b3670f2af452c1104b09ac6 |
| Headers | show |
Hi Thomas, On Thu, 14 Jan 2016 15:44:49 +0100 Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Since commit 17799359e7b3fa6ef4f2bf926cd6821cf7903ecf ("mtd: nand_bbt: > make nand_scan_bbt() static"), the nand_scan_bbt() function is marked > as static but is still exported using EXPORT_SYMBOL(), which doesn't > make much sense. > > This commit gets rid of the useless EXPORT_SYMBOL. Hehe, I noticed this useless EXPORT_SYMBOL while reviewing the BBT rework, just forgot to post the patch removing it. Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com> Thanks, Boris > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > drivers/mtd/nand/nand_bbt.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mtd/nand/nand_bbt.c b/drivers/mtd/nand/nand_bbt.c > index b1d4f81..4dfaf93 100644 > --- a/drivers/mtd/nand/nand_bbt.c > +++ b/drivers/mtd/nand/nand_bbt.c > @@ -1373,5 +1373,3 @@ int nand_markbad_bbt(struct mtd_info *mtd, loff_t offs) > > return ret; > } > - > -EXPORT_SYMBOL(nand_scan_bbt);
On Thu, Jan 14, 2016 at 03:44:49PM +0100, Thomas Petazzoni wrote: > Since commit 17799359e7b3fa6ef4f2bf926cd6821cf7903ecf ("mtd: nand_bbt: > make nand_scan_bbt() static"), the nand_scan_bbt() function is marked > as static but is still exported using EXPORT_SYMBOL(), which doesn't > make much sense. > > This commit gets rid of the useless EXPORT_SYMBOL. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Pushed all 3 to l2-mtd.git/next
diff --git a/drivers/mtd/nand/nand_bbt.c b/drivers/mtd/nand/nand_bbt.c index b1d4f81..4dfaf93 100644 --- a/drivers/mtd/nand/nand_bbt.c +++ b/drivers/mtd/nand/nand_bbt.c @@ -1373,5 +1373,3 @@ int nand_markbad_bbt(struct mtd_info *mtd, loff_t offs) return ret; } - -EXPORT_SYMBOL(nand_scan_bbt);
Since commit 17799359e7b3fa6ef4f2bf926cd6821cf7903ecf ("mtd: nand_bbt: make nand_scan_bbt() static"), the nand_scan_bbt() function is marked as static but is still exported using EXPORT_SYMBOL(), which doesn't make much sense. This commit gets rid of the useless EXPORT_SYMBOL. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- drivers/mtd/nand/nand_bbt.c | 2 -- 1 file changed, 2 deletions(-)