Message ID | 1452702857-2240-2-git-send-email-romain.izard.pro@gmail.com |
---|---|
State | Accepted |
Headers | show |
On Wed, 13 Jan 2016 17:34:13 +0100 Romain Izard <romain.izard.pro@gmail.com> wrote: > When using multi-bit ECC, it is normal for the NAND Flash driver to > correct bit errors during the life of the product. Those errors will > only be cleared once a threshold has been reached, and corrections can > occur regularly before this. > > Use only dev_dbg and not dev_info to report the bitflips, to keep the > system log clean when everything works correctly. > > Signed-off-by: Romain Izard <romain.izard.pro@gmail.com> > Acked-by: Wenyou Yang <wenyou.yang@atmel.com> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com> > --- > drivers/mtd/nand/atmel_nand.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c > index 46010bd895b1..9d71f9e6a8de 100644 > --- a/drivers/mtd/nand/atmel_nand.c > +++ b/drivers/mtd/nand/atmel_nand.c > @@ -824,7 +824,7 @@ static void pmecc_correct_data(struct mtd_info *mtd, uint8_t *buf, uint8_t *ecc, > *(buf + byte_pos) ^= (1 << bit_pos); > > pos = sector_num * host->pmecc_sector_size + byte_pos; > - dev_info(host->dev, "Bit flip in data area, byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n", > + dev_dbg(host->dev, "Bit flip in data area, byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n", > pos, bit_pos, err_byte, *(buf + byte_pos)); > } else { > /* Bit flip in OOB area */ > @@ -834,7 +834,7 @@ static void pmecc_correct_data(struct mtd_info *mtd, uint8_t *buf, uint8_t *ecc, > ecc[tmp] ^= (1 << bit_pos); > > pos = tmp + nand_chip->ecc.layout->eccpos[0]; > - dev_info(host->dev, "Bit flip in OOB, oob_byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n", > + dev_dbg(host->dev, "Bit flip in OOB, oob_byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n", > pos, bit_pos, err_byte, ecc[tmp]); > } >
On Wed, Jan 13, 2016 at 06:54:21PM +0100, Boris Brezillon wrote: > On Wed, 13 Jan 2016 17:34:13 +0100 > Romain Izard <romain.izard.pro@gmail.com> wrote: > > > When using multi-bit ECC, it is normal for the NAND Flash driver to > > correct bit errors during the life of the product. Those errors will > > only be cleared once a threshold has been reached, and corrections can > > occur regularly before this. > > > > Use only dev_dbg and not dev_info to report the bitflips, to keep the > > system log clean when everything works correctly. > > > > Signed-off-by: Romain Izard <romain.izard.pro@gmail.com> > > Acked-by: Wenyou Yang <wenyou.yang@atmel.com> > > Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com> Pushed patch 1 to l2-mtd.git/next
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c index 46010bd895b1..9d71f9e6a8de 100644 --- a/drivers/mtd/nand/atmel_nand.c +++ b/drivers/mtd/nand/atmel_nand.c @@ -824,7 +824,7 @@ static void pmecc_correct_data(struct mtd_info *mtd, uint8_t *buf, uint8_t *ecc, *(buf + byte_pos) ^= (1 << bit_pos); pos = sector_num * host->pmecc_sector_size + byte_pos; - dev_info(host->dev, "Bit flip in data area, byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n", + dev_dbg(host->dev, "Bit flip in data area, byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n", pos, bit_pos, err_byte, *(buf + byte_pos)); } else { /* Bit flip in OOB area */ @@ -834,7 +834,7 @@ static void pmecc_correct_data(struct mtd_info *mtd, uint8_t *buf, uint8_t *ecc, ecc[tmp] ^= (1 << bit_pos); pos = tmp + nand_chip->ecc.layout->eccpos[0]; - dev_info(host->dev, "Bit flip in OOB, oob_byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n", + dev_dbg(host->dev, "Bit flip in OOB, oob_byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n", pos, bit_pos, err_byte, ecc[tmp]); }