Patchwork virtio-serial: Fix compat property name

login
register
mail settings
Submitter Amit Shah
Date June 23, 2010, 5:19 p.m.
Message ID <bf011955462f84301f70f9349e9df58c2269f176.1277313553.git.amit.shah@redhat.com>
Download mbox | patch
Permalink /patch/56696/
State New
Headers show

Comments

Amit Shah - June 23, 2010, 5:19 p.m.
Starting with qemu -M pc-0.12 -device virtio-serial

results in

-device virtio-serial: Property 'virtio-serial-pci.max_nr_ports' not found

The property name 'max_ports' is incorrectly named 'max_nr_ports'. Fix
that.

Also fix the ppc440 machine type bamboo-0.12 which has this typo.

Reported-by: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
 hw/pc_piix.c       |    6 +++---
 hw/ppc440_bamboo.c |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
Amit Shah - July 14, 2010, 1:31 p.m.
On (Wed) Jun 23 2010 [22:49:20], Amit Shah wrote:
> Starting with qemu -M pc-0.12 -device virtio-serial
> 
> results in
> 
> -device virtio-serial: Property 'virtio-serial-pci.max_nr_ports' not found
> 
> The property name 'max_ports' is incorrectly named 'max_nr_ports'. Fix
> that.
> 
> Also fix the ppc440 machine type bamboo-0.12 which has this typo.
> 
> Reported-by: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>

Ping

		Amit
Aurelien Jarno - July 22, 2010, 12:14 p.m.
On Wed, Jun 23, 2010 at 10:49:20PM +0530, Amit Shah wrote:
> Starting with qemu -M pc-0.12 -device virtio-serial
> 
> results in
> 
> -device virtio-serial: Property 'virtio-serial-pci.max_nr_ports' not found
> 
> The property name 'max_ports' is incorrectly named 'max_nr_ports'. Fix
> that.
> 
> Also fix the ppc440 machine type bamboo-0.12 which has this typo.
> 
> Reported-by: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
> ---
>  hw/pc_piix.c       |    6 +++---
>  hw/ppc440_bamboo.c |    2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)

Thanks, applied.

> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
> index 68040b7..84e6c7f 100644
> --- a/hw/pc_piix.c
> +++ b/hw/pc_piix.c
> @@ -222,7 +222,7 @@ static QEMUMachine pc_machine_v0_12 = {
>      .compat_props = (GlobalProperty[]) {
>          {
>              .driver   = "virtio-serial-pci",
> -            .property = "max_nr_ports",
> +            .property = "max_ports",
>              .value    = stringify(1),
>          },{
>              .driver   = "virtio-serial-pci",
> @@ -245,7 +245,7 @@ static QEMUMachine pc_machine_v0_11 = {
>              .value    = stringify(0),
>          },{
>              .driver   = "virtio-serial-pci",
> -            .property = "max_nr_ports",
> +            .property = "max_ports",
>              .value    = stringify(1),
>          },{
>              .driver   = "virtio-serial-pci",
> @@ -284,7 +284,7 @@ static QEMUMachine pc_machine_v0_10 = {
>              .value    = stringify(PCI_CLASS_DISPLAY_OTHER),
>          },{
>              .driver   = "virtio-serial-pci",
> -            .property = "max_nr_ports",
> +            .property = "max_ports",
>              .value    = stringify(1),
>          },{
>              .driver   = "virtio-serial-pci",
> diff --git a/hw/ppc440_bamboo.c b/hw/ppc440_bamboo.c
> index 6ca873e..d471d5d 100644
> --- a/hw/ppc440_bamboo.c
> +++ b/hw/ppc440_bamboo.c
> @@ -186,7 +186,7 @@ static QEMUMachine bamboo_machine_v0_12 = {
>      .compat_props = (GlobalProperty[]) {
>          {
>              .driver   = "virtio-serial-pci",
> -            .property = "max_nr_ports",
> +            .property = "max_ports",
>              .value    = stringify(1),
>          },{
>              .driver   = "virtio-serial-pci",
> -- 
> 1.7.0.1
> 
> 
>

Patch

diff --git a/hw/pc_piix.c b/hw/pc_piix.c
index 68040b7..84e6c7f 100644
--- a/hw/pc_piix.c
+++ b/hw/pc_piix.c
@@ -222,7 +222,7 @@  static QEMUMachine pc_machine_v0_12 = {
     .compat_props = (GlobalProperty[]) {
         {
             .driver   = "virtio-serial-pci",
-            .property = "max_nr_ports",
+            .property = "max_ports",
             .value    = stringify(1),
         },{
             .driver   = "virtio-serial-pci",
@@ -245,7 +245,7 @@  static QEMUMachine pc_machine_v0_11 = {
             .value    = stringify(0),
         },{
             .driver   = "virtio-serial-pci",
-            .property = "max_nr_ports",
+            .property = "max_ports",
             .value    = stringify(1),
         },{
             .driver   = "virtio-serial-pci",
@@ -284,7 +284,7 @@  static QEMUMachine pc_machine_v0_10 = {
             .value    = stringify(PCI_CLASS_DISPLAY_OTHER),
         },{
             .driver   = "virtio-serial-pci",
-            .property = "max_nr_ports",
+            .property = "max_ports",
             .value    = stringify(1),
         },{
             .driver   = "virtio-serial-pci",
diff --git a/hw/ppc440_bamboo.c b/hw/ppc440_bamboo.c
index 6ca873e..d471d5d 100644
--- a/hw/ppc440_bamboo.c
+++ b/hw/ppc440_bamboo.c
@@ -186,7 +186,7 @@  static QEMUMachine bamboo_machine_v0_12 = {
     .compat_props = (GlobalProperty[]) {
         {
             .driver   = "virtio-serial-pci",
-            .property = "max_nr_ports",
+            .property = "max_ports",
             .value    = stringify(1),
         },{
             .driver   = "virtio-serial-pci",