| Message ID | 1452672007-330-1-git-send-email-wni@nvidia.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Wed, Jan 13, 2016 at 04:00:07PM +0800, Wei Ni wrote: > Add sysfs interface to dump registers for debug. You're adding a debugfs interface here, not sysfs. > diff --git a/drivers/thermal/tegra/tegra_soctherm.c b/drivers/thermal/tegra/tegra_soctherm.c [...] > +#ifdef CONFIG_DEBUG_FS > +static int regs_show(struct seq_file *s, void *data) > +{ > + struct platform_device *pdev = s->private; > + struct tegra_soctherm *ts = platform_get_drvdata(pdev); > + struct tegra_tsensor *tsensors = ts->tsensors; > + u32 r, state; > + int i; > + > + seq_puts(s, "-----TSENSE (convert HW)-----\n"); > + > + for (i = 0; tsensors[i].name; i++) { > + r = readl(ts->regs + tsensors[i].base + SENSOR_CONFIG1); > + state = REG_GET_MASK(r, SENSOR_CONFIG1_TEMP_ENABLE); > + if (!state) > + continue; > + > + seq_printf(s, "%s: ", tsensors[i].name); > + > + seq_printf(s, "En(%d) ", state); > + state = REG_GET_MASK(r, SENSOR_CONFIG1_TIDDQ_EN_MASK); > + seq_printf(s, "tiddq(%d) ", state); > + state = REG_GET_MASK(r, SENSOR_CONFIG1_TEN_COUNT_MASK); > + seq_printf(s, "ten_count(%d) ", state); > + state = REG_GET_MASK(r, SENSOR_CONFIG1_TSAMPLE_MASK); > + seq_printf(s, "tsample(%d) ", state + 1); > + > + r = readl(ts->regs + tsensors[i].base + SENSOR_STATUS1); > + state = REG_GET_MASK(r, SENSOR_STATUS1_TEMP_VALID_MASK); > + seq_printf(s, "Temp(%d/", state); > + state = REG_GET_MASK(r, SENSOR_STATUS1_TEMP_MASK); > + seq_printf(s, "%d) ", translate_temp(state)); > + > + r = readl(ts->regs + tsensors[i].base + SENSOR_STATUS0); > + state = REG_GET_MASK(r, SENSOR_STATUS0_VALID_MASK); > + seq_printf(s, "Capture(%d/", state); > + state = REG_GET_MASK(r, SENSOR_STATUS0_CAPTURE_MASK); > + seq_printf(s, "%d) ", state); > + > + r = readl(ts->regs + tsensors[i].base + SENSOR_CONFIG0); > + state = REG_GET_MASK(r, SENSOR_CONFIG0_STOP); > + seq_printf(s, "Stop(%d) ", state); > + state = REG_GET_MASK(r, SENSOR_CONFIG0_TALL_MASK); > + seq_printf(s, "Tall(%d) ", state); > + state = REG_GET_MASK(r, SENSOR_CONFIG0_TCALC_OVER); > + seq_printf(s, "Over(%d/", state); > + state = REG_GET_MASK(r, SENSOR_CONFIG0_OVER); > + seq_printf(s, "%d/", state); > + state = REG_GET_MASK(r, SENSOR_CONFIG0_CPTR_OVER); > + seq_printf(s, "%d) ", state); > + > + r = readl(ts->regs + tsensors[i].base + SENSOR_CONFIG2); > + state = REG_GET_MASK(r, SENSOR_CONFIG2_THERMA_MASK); > + seq_printf(s, "Therm_A/B(%d/", state); > + state = REG_GET_MASK(r, SENSOR_CONFIG2_THERMB_MASK); > + seq_printf(s, "%d)\n", (s16)state); > + } This isn't really a register dump, it's a decoded form of the register contents. I think it'd be better to either provide a debugfs file with the raw register contents, perhaps with register name and offset, or a decoded version. Or both. > + > + r = readl(ts->regs + SENSOR_PDIV); > + seq_printf(s, "PDIV: 0x%x\n", r); > + > + r = readl(ts->regs + SENSOR_HOTSPOT_OFF); > + seq_printf(s, "HOTSPOT: 0x%x\n", r); > + > + seq_puts(s, "\n"); > + seq_puts(s, "-----SOC_THERM-----\n"); I don't think these separators are any good. debugfs files are essentially for free, so if you have logical separation of the content, as indicated by the separator here, a better option would be to make these separate files. > + r = readl(ts->regs + SENSOR_TEMP1); > + state = REG_GET_MASK(r, SENSOR_TEMP1_CPU_TEMP_MASK); > + seq_printf(s, "Temperatures: CPU(%d) ", translate_temp(state)); > + state = REG_GET_MASK(r, SENSOR_TEMP1_GPU_TEMP_MASK); > + seq_printf(s, " GPU(%d) ", translate_temp(state)); > + r = readl(ts->regs + SENSOR_TEMP2); > + state = REG_GET_MASK(r, SENSOR_TEMP2_PLLX_TEMP_MASK); > + seq_printf(s, " PLLX(%d) ", translate_temp(state)); > + state = REG_GET_MASK(r, SENSOR_TEMP2_MEM_TEMP_MASK); > + seq_printf(s, " MEM(%d)\n", translate_temp(state)); Isn't this something that the thermal core support already exports via some interface? > +static int soctherm_debug_init(struct platform_device *pdev) > +{ > + struct dentry *tegra_soctherm_root; > + > + tegra_soctherm_root = debugfs_create_dir("tegra_soctherm", NULL); You should check for potential failure here, otherwise you might end up in a situation where you create the soctherm files in the debugfs root, which is almost certainly not what you want. > + debugfs_create_file("regs", 0644, tegra_soctherm_root, > + pdev, ®s_fops); > + > + return 0; > +} > +#else > +static inline int soctherm_debug_init(struct platform_device *pdev) > +{ return 0; } > +#endif > + > int tegra_soctherm_probe(struct platform_device *pdev, > struct tegra_tsensor *tsensors, > const struct tegra_tsensor_group **ttgs, > @@ -154,6 +276,10 @@ int tegra_soctherm_probe(struct platform_device *pdev, > if (!tegra) > return -ENOMEM; > > + dev_set_drvdata(&pdev->dev, tegra); > + > + tegra->tsensors = tsensors; > + > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > tegra->regs = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(tegra->regs)) > @@ -243,6 +369,8 @@ int tegra_soctherm_probe(struct platform_device *pdev, > tegra->thermctl_tzs[ttgs[i]->id] = tz; > } > > + soctherm_debug_init(pdev); If you never check and don't care about the return value, I suggest making the soctherm_debugfs_init() function return void. You should still check for errors within the function to make sure you're not doing anything you shouldn't, but you can silently ignore errors if you don't care, or perhaps give an indication as to what failed with a dev_warn() or similar. Thierry
On 2016年01月13日 23:17, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Wed, Jan 13, 2016 at 04:00:07PM +0800, Wei Ni wrote: >> Add sysfs interface to dump registers for debug. > > You're adding a debugfs interface here, not sysfs. Oh, sorry, should be debugfs. > >> diff --git a/drivers/thermal/tegra/tegra_soctherm.c b/drivers/thermal/tegra/tegra_soctherm.c > [...] >> +#ifdef CONFIG_DEBUG_FS >> +static int regs_show(struct seq_file *s, void *data) >> +{ >> + struct platform_device *pdev = s->private; >> + struct tegra_soctherm *ts = platform_get_drvdata(pdev); >> + struct tegra_tsensor *tsensors = ts->tsensors; >> + u32 r, state; >> + int i; >> + >> + seq_puts(s, "-----TSENSE (convert HW)-----\n"); >> + >> + for (i = 0; tsensors[i].name; i++) { >> + r = readl(ts->regs + tsensors[i].base + SENSOR_CONFIG1); >> + state = REG_GET_MASK(r, SENSOR_CONFIG1_TEMP_ENABLE); >> + if (!state) >> + continue; >> + >> + seq_printf(s, "%s: ", tsensors[i].name); >> + >> + seq_printf(s, "En(%d) ", state); >> + state = REG_GET_MASK(r, SENSOR_CONFIG1_TIDDQ_EN_MASK); >> + seq_printf(s, "tiddq(%d) ", state); >> + state = REG_GET_MASK(r, SENSOR_CONFIG1_TEN_COUNT_MASK); >> + seq_printf(s, "ten_count(%d) ", state); >> + state = REG_GET_MASK(r, SENSOR_CONFIG1_TSAMPLE_MASK); >> + seq_printf(s, "tsample(%d) ", state + 1); >> + >> + r = readl(ts->regs + tsensors[i].base + SENSOR_STATUS1); >> + state = REG_GET_MASK(r, SENSOR_STATUS1_TEMP_VALID_MASK); >> + seq_printf(s, "Temp(%d/", state); >> + state = REG_GET_MASK(r, SENSOR_STATUS1_TEMP_MASK); >> + seq_printf(s, "%d) ", translate_temp(state)); >> + >> + r = readl(ts->regs + tsensors[i].base + SENSOR_STATUS0); >> + state = REG_GET_MASK(r, SENSOR_STATUS0_VALID_MASK); >> + seq_printf(s, "Capture(%d/", state); >> + state = REG_GET_MASK(r, SENSOR_STATUS0_CAPTURE_MASK); >> + seq_printf(s, "%d) ", state); >> + >> + r = readl(ts->regs + tsensors[i].base + SENSOR_CONFIG0); >> + state = REG_GET_MASK(r, SENSOR_CONFIG0_STOP); >> + seq_printf(s, "Stop(%d) ", state); >> + state = REG_GET_MASK(r, SENSOR_CONFIG0_TALL_MASK); >> + seq_printf(s, "Tall(%d) ", state); >> + state = REG_GET_MASK(r, SENSOR_CONFIG0_TCALC_OVER); >> + seq_printf(s, "Over(%d/", state); >> + state = REG_GET_MASK(r, SENSOR_CONFIG0_OVER); >> + seq_printf(s, "%d/", state); >> + state = REG_GET_MASK(r, SENSOR_CONFIG0_CPTR_OVER); >> + seq_printf(s, "%d) ", state); >> + >> + r = readl(ts->regs + tsensors[i].base + SENSOR_CONFIG2); >> + state = REG_GET_MASK(r, SENSOR_CONFIG2_THERMA_MASK); >> + seq_printf(s, "Therm_A/B(%d/", state); >> + state = REG_GET_MASK(r, SENSOR_CONFIG2_THERMB_MASK); >> + seq_printf(s, "%d)\n", (s16)state); >> + } > > This isn't really a register dump, it's a decoded form of the register > contents. I think it'd be better to either provide a debugfs file with > the raw register contents, perhaps with register name and offset, or a > decoded version. Or both. Yes, you are right, it's a decoded form of register contents. > >> + >> + r = readl(ts->regs + SENSOR_PDIV); >> + seq_printf(s, "PDIV: 0x%x\n", r); >> + >> + r = readl(ts->regs + SENSOR_HOTSPOT_OFF); >> + seq_printf(s, "HOTSPOT: 0x%x\n", r); >> + >> + seq_puts(s, "\n"); >> + seq_puts(s, "-----SOC_THERM-----\n"); > > I don't think these separators are any good. debugfs files are > essentially for free, so if you have logical separation of the content, > as indicated by the separator here, a better option would be to make > these separate files. This is the decoded form. To make it more readable, I add this separators, and I will add more contents which should belong to it. This debugfs file is something like: root@tegra-ubuntu:/sys/kernel/debug/tegra_soctherm# cat regs -----TSENSE (convert HW)----- cpu0: En(1) tiddq(1) ten_count(1) tsample(120) Temp(1/26500) Capture(1/8471) Stop(0) Tall(16300) Over(0/0/0) Therm_A/B(1683/-1687) cpu1: En(1) tiddq(1) ten_count(1) tsample(120) Temp(1/25500) Capture(1/8653) Stop(0) Tall(16300) Over(0/0/0) Therm_A/B(1800/-1850) cpu2: En(1) tiddq(1) ten_count(1) tsample(120) Temp(1/28000) Capture(1/8386) Stop(0) Tall(16300) Over(0/0/0) Therm_A/B(1709/-1693) cpu3: En(1) tiddq(1) ten_count(1) tsample(120) Temp(1/26500) Capture(1/8402) Stop(0) Tall(16300) Over(0/0/0) Therm_A/B(1732/-1723) mem0: En(1) tiddq(1) ten_count(1) tsample(120) Temp(1/27000) Capture(1/8552) Stop(0) Tall(16300) Over(0/0/0) Therm_A/B(1670/-1689) mem1: En(1) tiddq(1) ten_count(1) tsample(120) Temp(1/25500) Capture(1/8691) Stop(0) Tall(16300) Over(0/0/0) Therm_A/B(1911/-1976) gpu: En(1) tiddq(1) ten_count(1) tsample(120) Temp(0/0) Capture(0/0) Stop(0) Tall(16300) Over(0/0/0) Therm_A/B(1714/-1730) pllx: En(1) tiddq(1) ten_count(1) tsample(120) Temp(1/26500) Capture(1/8465) Stop(0) Tall(16300) Over(0/0/0) Therm_A/B(1644/-1645) PDIV: 0x8888 HOTSPOT: 0xa0500 -----SOC_THERM----- Temperatures: CPU(28000) GPU(29000) PLLX(26500) MEM(27000) > >> + r = readl(ts->regs + SENSOR_TEMP1); >> + state = REG_GET_MASK(r, SENSOR_TEMP1_CPU_TEMP_MASK); >> + seq_printf(s, "Temperatures: CPU(%d) ", translate_temp(state)); >> + state = REG_GET_MASK(r, SENSOR_TEMP1_GPU_TEMP_MASK); >> + seq_printf(s, " GPU(%d) ", translate_temp(state)); >> + r = readl(ts->regs + SENSOR_TEMP2); >> + state = REG_GET_MASK(r, SENSOR_TEMP2_PLLX_TEMP_MASK); >> + seq_printf(s, " PLLX(%d) ", translate_temp(state)); >> + state = REG_GET_MASK(r, SENSOR_TEMP2_MEM_TEMP_MASK); >> + seq_printf(s, " MEM(%d)\n", translate_temp(state)); > > Isn't this something that the thermal core support already exports via > some interface? Hmm, yes, I add them to here so that we can check all HW information in this file. > >> +static int soctherm_debug_init(struct platform_device *pdev) >> +{ >> + struct dentry *tegra_soctherm_root; >> + >> + tegra_soctherm_root = debugfs_create_dir("tegra_soctherm", NULL); > > You should check for potential failure here, otherwise you might end up > in a situation where you create the soctherm files in the debugfs root, > which is almost certainly not what you want. Yes, you are right, will check the return value. > >> + debugfs_create_file("regs", 0644, tegra_soctherm_root, >> + pdev, ®s_fops); >> + >> + return 0; >> +} >> +#else >> +static inline int soctherm_debug_init(struct platform_device *pdev) >> +{ return 0; } >> +#endif >> + >> int tegra_soctherm_probe(struct platform_device *pdev, >> struct tegra_tsensor *tsensors, >> const struct tegra_tsensor_group **ttgs, >> @@ -154,6 +276,10 @@ int tegra_soctherm_probe(struct platform_device *pdev, >> if (!tegra) >> return -ENOMEM; >> >> + dev_set_drvdata(&pdev->dev, tegra); >> + >> + tegra->tsensors = tsensors; >> + >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> tegra->regs = devm_ioremap_resource(&pdev->dev, res); >> if (IS_ERR(tegra->regs)) >> @@ -243,6 +369,8 @@ int tegra_soctherm_probe(struct platform_device *pdev, >> tegra->thermctl_tzs[ttgs[i]->id] = tz; >> } >> >> + soctherm_debug_init(pdev); > > If you never check and don't care about the return value, I suggest > making the soctherm_debugfs_init() function return void. You should > still check for errors within the function to make sure you're not > doing anything you shouldn't, but you can silently ignore errors if > you don't care, or perhaps give an indication as to what failed with > a dev_warn() or similar. Yes, you are right, I will change to return void. > > Thierry > > * Unknown Key > * 0x7F3EB3A1 > -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/thermal/tegra/tegra_soctherm.c b/drivers/thermal/tegra/tegra_soctherm.c index cc5a3e14948f..c28d0a2a3ff9 100644 --- a/drivers/thermal/tegra/tegra_soctherm.c +++ b/drivers/thermal/tegra/tegra_soctherm.c @@ -15,6 +15,7 @@ * */ +#include <linux/debugfs.h> #include <linux/bitops.h> #include <linux/clk.h> #include <linux/delay.h> @@ -33,14 +34,18 @@ #define SENSOR_CONFIG0 0 #define SENSOR_CONFIG0_STOP BIT(0) -#define SENSOR_CONFIG0_TALL_SHIFT 8 -#define SENSOR_CONFIG0_TCALC_OVER BIT(4) -#define SENSOR_CONFIG0_OVER BIT(3) #define SENSOR_CONFIG0_CPTR_OVER BIT(2) +#define SENSOR_CONFIG0_OVER BIT(3) +#define SENSOR_CONFIG0_TCALC_OVER BIT(4) +#define SENSOR_CONFIG0_TALL_MASK (0xfffff << 8) +#define SENSOR_CONFIG0_TALL_SHIFT 8 #define SENSOR_CONFIG1 4 +#define SENSOR_CONFIG1_TSAMPLE_MASK 0x3ff #define SENSOR_CONFIG1_TSAMPLE_SHIFT 0 +#define SENSOR_CONFIG1_TIDDQ_EN_MASK (0x3f << 15) #define SENSOR_CONFIG1_TIDDQ_EN_SHIFT 15 +#define SENSOR_CONFIG1_TEN_COUNT_MASK (0x3f << 24) #define SENSOR_CONFIG1_TEN_COUNT_SHIFT 24 #define SENSOR_CONFIG1_TEMP_ENABLE BIT(31) @@ -49,6 +54,14 @@ * because, it will be used by tegra_soctherm_fuse.c */ +#define SENSOR_STATUS0 0xc +#define SENSOR_STATUS0_VALID_MASK BIT(31) +#define SENSOR_STATUS0_CAPTURE_MASK 0xffff + +#define SENSOR_STATUS1 0x10 +#define SENSOR_STATUS1_TEMP_VALID_MASK BIT(31) +#define SENSOR_STATUS1_TEMP_MASK 0xffff + #define READBACK_VALUE_MASK 0xff00 #define READBACK_VALUE_SHIFT 8 #define READBACK_ADD_HALF BIT(7) @@ -72,6 +85,7 @@ struct tegra_soctherm { void __iomem *regs; struct thermal_zone_device *thermctl_tzs[TEGRA124_SOCTHERM_SENSOR_NUM]; + struct tegra_tsensor *tsensors; }; static int enable_tsensor(struct tegra_soctherm *tegra, @@ -137,6 +151,114 @@ static const struct thermal_zone_of_device_ops tegra_of_thermal_ops = { .get_temp = tegra_thermctl_get_temp, }; +#ifdef CONFIG_DEBUG_FS +static int regs_show(struct seq_file *s, void *data) +{ + struct platform_device *pdev = s->private; + struct tegra_soctherm *ts = platform_get_drvdata(pdev); + struct tegra_tsensor *tsensors = ts->tsensors; + u32 r, state; + int i; + + seq_puts(s, "-----TSENSE (convert HW)-----\n"); + + for (i = 0; tsensors[i].name; i++) { + r = readl(ts->regs + tsensors[i].base + SENSOR_CONFIG1); + state = REG_GET_MASK(r, SENSOR_CONFIG1_TEMP_ENABLE); + if (!state) + continue; + + seq_printf(s, "%s: ", tsensors[i].name); + + seq_printf(s, "En(%d) ", state); + state = REG_GET_MASK(r, SENSOR_CONFIG1_TIDDQ_EN_MASK); + seq_printf(s, "tiddq(%d) ", state); + state = REG_GET_MASK(r, SENSOR_CONFIG1_TEN_COUNT_MASK); + seq_printf(s, "ten_count(%d) ", state); + state = REG_GET_MASK(r, SENSOR_CONFIG1_TSAMPLE_MASK); + seq_printf(s, "tsample(%d) ", state + 1); + + r = readl(ts->regs + tsensors[i].base + SENSOR_STATUS1); + state = REG_GET_MASK(r, SENSOR_STATUS1_TEMP_VALID_MASK); + seq_printf(s, "Temp(%d/", state); + state = REG_GET_MASK(r, SENSOR_STATUS1_TEMP_MASK); + seq_printf(s, "%d) ", translate_temp(state)); + + r = readl(ts->regs + tsensors[i].base + SENSOR_STATUS0); + state = REG_GET_MASK(r, SENSOR_STATUS0_VALID_MASK); + seq_printf(s, "Capture(%d/", state); + state = REG_GET_MASK(r, SENSOR_STATUS0_CAPTURE_MASK); + seq_printf(s, "%d) ", state); + + r = readl(ts->regs + tsensors[i].base + SENSOR_CONFIG0); + state = REG_GET_MASK(r, SENSOR_CONFIG0_STOP); + seq_printf(s, "Stop(%d) ", state); + state = REG_GET_MASK(r, SENSOR_CONFIG0_TALL_MASK); + seq_printf(s, "Tall(%d) ", state); + state = REG_GET_MASK(r, SENSOR_CONFIG0_TCALC_OVER); + seq_printf(s, "Over(%d/", state); + state = REG_GET_MASK(r, SENSOR_CONFIG0_OVER); + seq_printf(s, "%d/", state); + state = REG_GET_MASK(r, SENSOR_CONFIG0_CPTR_OVER); + seq_printf(s, "%d) ", state); + + r = readl(ts->regs + tsensors[i].base + SENSOR_CONFIG2); + state = REG_GET_MASK(r, SENSOR_CONFIG2_THERMA_MASK); + seq_printf(s, "Therm_A/B(%d/", state); + state = REG_GET_MASK(r, SENSOR_CONFIG2_THERMB_MASK); + seq_printf(s, "%d)\n", (s16)state); + } + + r = readl(ts->regs + SENSOR_PDIV); + seq_printf(s, "PDIV: 0x%x\n", r); + + r = readl(ts->regs + SENSOR_HOTSPOT_OFF); + seq_printf(s, "HOTSPOT: 0x%x\n", r); + + seq_puts(s, "\n"); + seq_puts(s, "-----SOC_THERM-----\n"); + + r = readl(ts->regs + SENSOR_TEMP1); + state = REG_GET_MASK(r, SENSOR_TEMP1_CPU_TEMP_MASK); + seq_printf(s, "Temperatures: CPU(%d) ", translate_temp(state)); + state = REG_GET_MASK(r, SENSOR_TEMP1_GPU_TEMP_MASK); + seq_printf(s, " GPU(%d) ", translate_temp(state)); + r = readl(ts->regs + SENSOR_TEMP2); + state = REG_GET_MASK(r, SENSOR_TEMP2_PLLX_TEMP_MASK); + seq_printf(s, " PLLX(%d) ", translate_temp(state)); + state = REG_GET_MASK(r, SENSOR_TEMP2_MEM_TEMP_MASK); + seq_printf(s, " MEM(%d)\n", translate_temp(state)); + + return 0; +} + +static int regs_open(struct inode *inode, struct file *file) +{ + return single_open(file, regs_show, inode->i_private); +} + +static const struct file_operations regs_fops = { + .open = regs_open, + .read = seq_read, + .llseek = seq_lseek, + .release = single_release, +}; + +static int soctherm_debug_init(struct platform_device *pdev) +{ + struct dentry *tegra_soctherm_root; + + tegra_soctherm_root = debugfs_create_dir("tegra_soctherm", NULL); + debugfs_create_file("regs", 0644, tegra_soctherm_root, + pdev, ®s_fops); + + return 0; +} +#else +static inline int soctherm_debug_init(struct platform_device *pdev) +{ return 0; } +#endif + int tegra_soctherm_probe(struct platform_device *pdev, struct tegra_tsensor *tsensors, const struct tegra_tsensor_group **ttgs, @@ -154,6 +276,10 @@ int tegra_soctherm_probe(struct platform_device *pdev, if (!tegra) return -ENOMEM; + dev_set_drvdata(&pdev->dev, tegra); + + tegra->tsensors = tsensors; + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); tegra->regs = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(tegra->regs)) @@ -243,6 +369,8 @@ int tegra_soctherm_probe(struct platform_device *pdev, tegra->thermctl_tzs[ttgs[i]->id] = tz; } + soctherm_debug_init(pdev); + return 0; unregister_tzs: diff --git a/drivers/thermal/tegra/tegra_soctherm.h b/drivers/thermal/tegra/tegra_soctherm.h index 8d06f4f75ff9..3ade453fc353 100644 --- a/drivers/thermal/tegra/tegra_soctherm.h +++ b/drivers/thermal/tegra/tegra_soctherm.h @@ -16,7 +16,9 @@ #define __DRIVERS_THERMAL_TEGRA_SOCTHERM_H #define SENSOR_CONFIG2 8 +#define SENSOR_CONFIG2_THERMA_MASK (0xffff << 16) #define SENSOR_CONFIG2_THERMA_SHIFT 16 +#define SENSOR_CONFIG2_THERMB_MASK 0xffff #define SENSOR_CONFIG2_THERMB_SHIFT 0 #define SENSOR_PDIV 0x1c0
Add sysfs interface to dump registers for debug. Signed-off-by: Wei Ni <wni@nvidia.com> --- drivers/thermal/tegra/tegra_soctherm.c | 134 ++++++++++++++++++++++++++++++++- drivers/thermal/tegra/tegra_soctherm.h | 2 + 2 files changed, 133 insertions(+), 3 deletions(-)