| Message ID | 1452605979-744-1-git-send-email-cfergeau@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 01/12/2016 06:39 AM, Christophe Fergeau wrote: > Signed-off-by: Christophe Fergeau <cfergeau@redhat.com> > --- > fsdev/virtfs-proxy-helper.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fsdev/virtfs-proxy-helper.texi b/fsdev/virtfs-proxy-helper.texi > index e60e3b9..1b905a0 100644 > --- a/fsdev/virtfs-proxy-helper.texi > +++ b/fsdev/virtfs-proxy-helper.texi > @@ -29,7 +29,7 @@ driver sends filesystem request to proxy helper and receives the > response from it. > > Proxy helper is designed so that it can drop the root privilege with > -retaining capbilities needed for doing filesystem operations only. > +retaining capabilities needed for doing filesystem operations only. Still reads awkwardly; better might be: The proxy helper is designed so that it can drop root privileges except for the capabilities needed for doing filesystem operations.
On Fri, Jan 15, 2016 at 04:31:45PM -0700, Eric Blake wrote: > On 01/12/2016 06:39 AM, Christophe Fergeau wrote: > > Signed-off-by: Christophe Fergeau <cfergeau@redhat.com> > > --- > > fsdev/virtfs-proxy-helper.texi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fsdev/virtfs-proxy-helper.texi b/fsdev/virtfs-proxy-helper.texi > > index e60e3b9..1b905a0 100644 > > --- a/fsdev/virtfs-proxy-helper.texi > > +++ b/fsdev/virtfs-proxy-helper.texi > > @@ -29,7 +29,7 @@ driver sends filesystem request to proxy helper and receives the > > response from it. > > > > Proxy helper is designed so that it can drop the root privilege with > > -retaining capbilities needed for doing filesystem operations only. > > +retaining capabilities needed for doing filesystem operations only. > > Still reads awkwardly; better might be: > > The proxy helper is designed so that it can drop root privileges except > for the capabilities needed for doing filesystem operations. Ok, I'll send a v2 changing the sentence to your suggestion, thanks! Christophe
diff --git a/fsdev/virtfs-proxy-helper.texi b/fsdev/virtfs-proxy-helper.texi index e60e3b9..1b905a0 100644 --- a/fsdev/virtfs-proxy-helper.texi +++ b/fsdev/virtfs-proxy-helper.texi @@ -29,7 +29,7 @@ driver sends filesystem request to proxy helper and receives the response from it. Proxy helper is designed so that it can drop the root privilege with -retaining capbilities needed for doing filesystem operations only. +retaining capabilities needed for doing filesystem operations only. @end table @c man end
Signed-off-by: Christophe Fergeau <cfergeau@redhat.com> --- fsdev/virtfs-proxy-helper.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)