diff mbox

drivers : i2c: Allow i2c devices share an interrupt

Message ID 1452585707-20294-1-git-send-email-ying.zhang22455@nxp.com
State Changes Requested
Headers show

Commit Message

Zhang Ying-22455 Jan. 12, 2016, 8:01 a.m. UTC
From: Ying Zhang <b40530@freescale.com>

The I2C devices on I2C1, I2C2, I2C3, I2C4 share interrupts,
but the flag is not set when requesting IRQ.

This patch set the flag to IRQF_SHARED.

Signed-off-by: Ying Zhang <ying.zhang22455@nxp.com>
---
 drivers/i2c/busses/i2c-imx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wolfram Sang Jan. 26, 2016, 6:08 a.m. UTC | #1
On Tue, Jan 12, 2016 at 04:01:47PM +0800, ying.zhang22455@nxp.com wrote:
> From: Ying Zhang <b40530@freescale.com>
> 
> The I2C devices on I2C1, I2C2, I2C3, I2C4 share interrupts,
> but the flag is not set when requesting IRQ.

For which SoC is that information? And with which devices is it shared?
Please update the commit message.

> 
> This patch set the flag to IRQF_SHARED.
> 
> Signed-off-by: Ying Zhang <ying.zhang22455@nxp.com>
> ---
>  drivers/i2c/busses/i2c-imx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index d4d8536..611b269 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -1094,7 +1094,7 @@ static int i2c_imx_probe(struct platform_device *pdev)
>  	}
>  
>  	/* Request IRQ */
> -	ret = devm_request_irq(&pdev->dev, irq, i2c_imx_isr, 0,
> +	ret = devm_request_irq(&pdev->dev, irq, i2c_imx_isr, IRQF_SHARED,
>  				pdev->name, i2c_imx);
>  	if (ret) {
>  		dev_err(&pdev->dev, "can't claim irq %d\n", irq);
diff mbox

Patch

diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index d4d8536..611b269 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -1094,7 +1094,7 @@  static int i2c_imx_probe(struct platform_device *pdev)
 	}
 
 	/* Request IRQ */
-	ret = devm_request_irq(&pdev->dev, irq, i2c_imx_isr, 0,
+	ret = devm_request_irq(&pdev->dev, irq, i2c_imx_isr, IRQF_SHARED,
 				pdev->name, i2c_imx);
 	if (ret) {
 		dev_err(&pdev->dev, "can't claim irq %d\n", irq);