Patchwork [Bug,592056] Re: qemu segmentation fault when create qcow2 image with qemu-img command

login
register
mail settings
Submitter Hao, Xudong
Date June 23, 2010, 8:38 a.m.
Message ID <20100623083827.15164.18341.malone@potassium.ubuntu.com>
Download mbox | patch
Permalink /patch/56616/
State New
Headers show

Comments

Hao, Xudong - June 23, 2010, 8:38 a.m.
This bug has been fixed on commit: kvm-commit:a63e16c655f9e68d49d6fae4275ffda16b1888b2, qemu-kvm commit:97011c7fce92f8c0928c9e94e9896f0dca1bdeb9. 
qcow.img file can be created by qemu-img successfully.                  

fixed patch:
     while (list && list->name) {
         if (get_option_parameter(dest, list->name) == NULL) {

Patch

diff --git a/qemu-option.c b/qemu-option.c
index acd74f9..f884865 100644
--- a/qemu-option.c
+++ b/qemu-option.c
@@ -378,6 +378,7 @@  QEMUOptionParameter
*append_option_parameters(QEMUOptionParameter *dest,
     num_options += count_option_parameters(list);

     dest = qemu_realloc(dest, (num_options + 1) *
sizeof(QEMUOptionParameter));
+    dest[num_dest_options].name = NULL;