| Message ID | 1452527821-12276-2-git-send-email-tom.leiming@gmail.com |
|---|---|
| State | Deferred, archived |
| Delegated to: | David Miller |
| Headers | show |
Hi Ming,
[auto build test ERROR on net-next/master]
[also build test ERROR on v4.4 next-20160111]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
url: https://github.com/0day-ci/linux/commits/Ming-Lei/bpf-support-percpu-ARRAY-map/20160112-000350
config: sparc64-allmodconfig (attached as .config)
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=sparc64
All error/warnings (new ones prefixed by >>):
kernel/bpf/map.c: In function 'map_delete_elem_nop':
>> kernel/bpf/map.c:24:10: error: 'EINVAL' undeclared (first use in this function)
return -EINVAL;
^
kernel/bpf/map.c:24:10: note: each undeclared identifier is reported only once for each function it appears in
>> kernel/bpf/map.c:25:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
vim +/EINVAL +24 kernel/bpf/map.c
18 {
19 return NULL;
20 }
21
22 int map_delete_elem_nop(struct bpf_map *map, void *key)
23 {
> 24 return -EINVAL;
> 25 }
26
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
diff --git a/kernel/bpf/Makefile b/kernel/bpf/Makefile index 13272582..191d54b 100644 --- a/kernel/bpf/Makefile +++ b/kernel/bpf/Makefile @@ -1,4 +1,4 @@ obj-y := core.o obj-$(CONFIG_BPF_SYSCALL) += syscall.o verifier.o inode.o helpers.o -obj-$(CONFIG_BPF_SYSCALL) += hashtab.o arraymap.o +obj-$(CONFIG_BPF_SYSCALL) += map.o hashtab.o arraymap.o diff --git a/kernel/bpf/bpf_map.h b/kernel/bpf/bpf_map.h new file mode 100644 index 0000000..7e596c1 --- /dev/null +++ b/kernel/bpf/bpf_map.h @@ -0,0 +1,9 @@ +#ifndef INT_BPF_MAP_COMMON_H +#define INT_BPF_MAP_COMMON_H + +#include <linux/bpf.h> + +extern void *map_lookup_elem_nop(struct bpf_map *map, void *key); +extern int map_delete_elem_nop(struct bpf_map *map, void *key); + +#endif diff --git a/kernel/bpf/map.c b/kernel/bpf/map.c new file mode 100644 index 0000000..bf113fb --- /dev/null +++ b/kernel/bpf/map.c @@ -0,0 +1,26 @@ +/* + * bpf map common stuff + * + * Copyright (c) 2016 Ming Lei + * + * Authors: + * Ming Lei <tom.leiming@gmail.com> + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation; either version + * 2 of the License, or (at your option) any later version. + */ + +#include <linux/bpf.h> + +void *map_lookup_elem_nop(struct bpf_map *map, void *key) +{ + return NULL; +} + +int map_delete_elem_nop(struct bpf_map *map, void *key) +{ + return -EINVAL; +} +
This patch introduces some nop functions of map callback for use in all map implementation. Signed-off-by: Ming Lei <tom.leiming@gmail.com> --- kernel/bpf/Makefile | 2 +- kernel/bpf/bpf_map.h | 9 +++++++++ kernel/bpf/map.c | 26 ++++++++++++++++++++++++++ 3 files changed, 36 insertions(+), 1 deletion(-) create mode 100644 kernel/bpf/bpf_map.h create mode 100644 kernel/bpf/map.c