| Message ID | 1277276075-29322-1-git-send-email-amit.salecha@qlogic.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Tue, 2010-06-22 at 23:54 -0700, Amit Kumar Salecha wrote: > From: Anirban Chakraborty <anirban.chakraborty@qlogic.com> > > netxen_nic and qlcnic driver depends on firmware_class module. [...] By the way, I noticed that these drivers are very similar, and it looks like qlcnic has code for a bunch of NetXen boards even though it doesn't include their device IDs in its device ID table. Have you considered merging the two? Ben.
Actually that is not actually reflect to board type. "board_type" is a encoding to find out number of physical port and phy speed. NX3031 (netxen_nic) and QLOGIC CNA (qlcnic) device have some common board form. But not all board types are valid for QLOGIC CNA device. We will clean this up. Thanks for pointing this out. -Amit -----Original Message----- From: Ben Hutchings [mailto:bhutchings@solarflare.com] Sent: Wednesday, June 23, 2010 4:49 PM To: Amit Salecha Cc: davem@davemloft.net; netdev@vger.kernel.org; Ameen Rahman; Anirban Chakraborty Subject: Re: [PATCH] net: add dependency on fw class module On Tue, 2010-06-22 at 23:54 -0700, Amit Kumar Salecha wrote: > From: Anirban Chakraborty <anirban.chakraborty@qlogic.com> > > netxen_nic and qlcnic driver depends on firmware_class module. [...] By the way, I noticed that these drivers are very similar, and it looks like qlcnic has code for a bunch of NetXen boards even though it doesn't include their device IDs in its device ID table. Have you considered merging the two? Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.
From: Amit Kumar Salecha <amit.salecha@qlogic.com> Date: Tue, 22 Jun 2010 23:54:35 -0700 > From: Anirban Chakraborty <anirban.chakraborty@qlogic.com> > > netxen_nic and qlcnic driver depends on firmware_class module. > > Signed-off-by: Anirban Chakraborty <anirban.chakraborty@qlogic.com> > Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com> Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index fe113d0..71e6f8f 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -2755,6 +2755,7 @@ config MYRI10GE_DCA config NETXEN_NIC tristate "NetXen Multi port (1/10) Gigabit Ethernet NIC" depends on PCI + select FW_LOADER help This enables the support for NetXen's Gigabit Ethernet card. @@ -2820,6 +2821,7 @@ config BNX2X config QLCNIC tristate "QLOGIC QLCNIC 1/10Gb Converged Ethernet NIC Support" depends on PCI + select FW_LOADER help This driver supports QLogic QLE8240 and QLE8242 Converged Ethernet devices.