diff mbox

[ARM,PR69194] Fix ICE in in extract_insn

Message ID 56939066.3020703@foss.arm.com
State New
Headers show

Commit Message

Kyrill Tkachov Jan. 11, 2016, 11:22 a.m. UTC 
Hi Kugan,

On 09/01/16 23:08, Kugan wrote:
>
> On 09/01/16 07:01, Jakub Jelinek wrote:
>> On Fri, Jan 08, 2016 at 11:43:34AM -0800, Jim Wilson wrote:
>>> Here is a smaller simpler testcase.  Only the first four args get
>>> passed in regs, so the fifth one has address equal to the virtual
>>> incoming args reg which triggers the failure.
>>>
>>> typedef __simd128_float32_t float32x4_t;
>>> float32x4_t
>>> sub (float32x4_t a, float32x4_t b, float32x4_t c, float32x4_t d, float32x4_t e)
>>> {
>>>    return __builtin_neon_vld1v4sf((const float *)&e);
>>> }
>>>
>>> The original testcase failed with linaro gcc 4.9.  I verified that
>>> this testcase fails with FSF gcc-5.3.0.
>> Looks much better.  I'll defer to ARM maintainers to ack this.
> Thanks for the review. Please find the patch with the required changes.
> Regression tested with trunk and gcc-5 for arn-none-linux-gnu with no
> new regression. Is this OK ?
>
> Kugan
>
>
> 2016-01-10  Kugan Vivekanandarajah  <kuganv@linaro.org>
> 	    Jim Wilson  <jim.wilson@linaro.org>
>
> 	PR target/69194
> 	* config/arm/arm-builtins.c (arm_expand_neon_args): Call
> 	copy_to_mode_reg instead of force_reg.
>
> gcc/testsuite/ChangeLog:
>
> 2016-01-10  Kugan Vivekanandarajah  <kuganv@linaro.org>
> 	    Jim Wilson  <jim.wilson@linaro.org>
>
> 	PR target/69194
> 	* gcc.target/arm/pr69194.C: New test.
>

Thanks,
Kyrill
diff mbox

Patch

diff --git a/gcc/testsuite/gcc.target/arm/pr69194.c b/gcc/testsuite/gcc.target/arm/pr69194.c
index e69de29..10630c1 100644
--- a/gcc/testsuite/gcc.target/arm/pr69194.c
+++ b/gcc/testsuite/gcc.target/arm/pr69194.c
@@ -0,0 +1,12 @@ 
+/* PR target/69194 */
+/* { dg-do-compile } */
+/* { dg-require-effective-target arm_neon } */
+/* { dg-options "-O2 -mfpu=neon -mfloat-abi=hard" } */
+

Please use:
/* { dg-require-effective-target arm_neon_ok } */
/* { dg-options "-O2" } */
/* { dg-add-options arm_neon } */

Ok with that change.