| Message ID | alpine.DEB.2.10.1601111146380.2512@hadrien |
|---|---|
| State | Superseded |
| Headers | show |
On Mon, Jan 11, 2016 at 11:48 AM, Julia Lawall <julia.lawall@lip6.fr> wrote: > Make sure (of/i2c/platform)_device_id tables are NULL terminated > > Generated by: scripts/coccinelle/misc/of_table.cocci > > CC: Laxman Dewangan <ldewangan@nvidia.com> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> > --- > > Please take the patch only if it's a positive warning. Thanks! This is merged into the MFD subsystem for the moment so patches have to go through Lee. Alternatively I can go back and fix it up later. Yours, Linus Walleij
On Thursday 14 January 2016 03:17 PM, Lee Jones wrote: > On Thu, 14 Jan 2016, Linus Walleij wrote: > >> On Mon, Jan 11, 2016 at 11:48 AM, Julia Lawall <julia.lawall@lip6.fr> wrote: >> >>> Make sure (of/i2c/platform)_device_id tables are NULL terminated >>> >>> Generated by: scripts/coccinelle/misc/of_table.cocci >>> >>> CC: Laxman Dewangan <ldewangan@nvidia.com> >>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> >>> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> >>> --- >>> >>> Please take the patch only if it's a positive warning. Thanks! >> This is merged into the MFD subsystem for the moment so patches >> have to go through Lee. >> >> Alternatively I can go back and fix it up later. > Pull request for v4.5 has already been sent. > > Feel free to take the patch into your tree post -rc1. Is the driver gpio-max77620 applied? I think still there is discussion going on the patches?
On Thu, 14 Jan 2016, Linus Walleij wrote: > On Mon, Jan 11, 2016 at 11:48 AM, Julia Lawall <julia.lawall@lip6.fr> wrote: > > > Make sure (of/i2c/platform)_device_id tables are NULL terminated > > > > Generated by: scripts/coccinelle/misc/of_table.cocci > > > > CC: Laxman Dewangan <ldewangan@nvidia.com> > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> > > --- > > > > Please take the patch only if it's a positive warning. Thanks! > > This is merged into the MFD subsystem for the moment so patches > have to go through Lee. > > Alternatively I can go back and fix it up later. Pull request for v4.5 has already been sent. Feel free to take the patch into your tree post -rc1.
On Thu, Jan 14, 2016 at 10:39 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote: > On Thursday 14 January 2016 03:17 PM, Lee Jones wrote: >> On Thu, 14 Jan 2016, Linus Walleij wrote: >> >>> On Mon, Jan 11, 2016 at 11:48 AM, Julia Lawall <julia.lawall@lip6.fr> >>> wrote: >>> >>>> Make sure (of/i2c/platform)_device_id tables are NULL terminated >>>> >>>> Generated by: scripts/coccinelle/misc/of_table.cocci >>>> >>>> CC: Laxman Dewangan <ldewangan@nvidia.com> >>>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> >>>> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> >>>> --- >>>> >>>> Please take the patch only if it's a positive warning. Thanks! >>> >>> This is merged into the MFD subsystem for the moment so patches >>> have to go through Lee. >>> >>> Alternatively I can go back and fix it up later. >> >> Pull request for v4.5 has already been sent. >> >> Feel free to take the patch into your tree post -rc1. > > Is the driver gpio-max77620 applied? Nah, I misunderstood it, don't worry. Lee just merged the core driver(s). I have no idea what Julia's patch is based on, I was confused by this mail so I assumed it was in the tree but it was not. The world is full of mysteries :D > I think still there is discussion going on the patches? Sure let's work on this for the next cycle. Yours, Linus Walleij
On Fri, 15 Jan 2016, Linus Walleij wrote: > On Thu, Jan 14, 2016 at 10:39 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote: > > On Thursday 14 January 2016 03:17 PM, Lee Jones wrote: > >> On Thu, 14 Jan 2016, Linus Walleij wrote: > >> > >>> On Mon, Jan 11, 2016 at 11:48 AM, Julia Lawall <julia.lawall@lip6.fr> > >>> wrote: > >>> > >>>> Make sure (of/i2c/platform)_device_id tables are NULL terminated > >>>> > >>>> Generated by: scripts/coccinelle/misc/of_table.cocci > >>>> > >>>> CC: Laxman Dewangan <ldewangan@nvidia.com> > >>>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > >>>> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> > >>>> --- > >>>> > >>>> Please take the patch only if it's a positive warning. Thanks! > >>> > >>> This is merged into the MFD subsystem for the moment so patches > >>> have to go through Lee. > >>> > >>> Alternatively I can go back and fix it up later. > >> > >> Pull request for v4.5 has already been sent. > >> > >> Feel free to take the patch into your tree post -rc1. > > > > Is the driver gpio-max77620 applied? > > Nah, I misunderstood it, don't worry. Lee just merged the core > driver(s). I have no idea what Julia's patch is based on, I was > confused by this mail so I assumed it was in the tree but it > was not. The world is full of mysteries :D I don't know either. It came to me via kbuild. It may be derived from a submitted patch rather than aready committed code. julia > > > I think still there is discussion going on the patches? > > Sure let's work on this for the next cycle. > > Yours, > Linus Walleij >
On Friday 15 January 2016 06:45 PM, Linus Walleij wrote: > On Thu, Jan 14, 2016 at 10:39 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote: >> I think still there is discussion going on the patches? > Sure let's work on this for the next cycle. > > I have fixed this in V3 version and sent for review. Please help to review it. Thanks, Laxman
--- a/drivers/gpio/gpio-max77620.c +++ b/drivers/gpio/gpio-max77620.c @@ -301,6 +301,7 @@ static struct platform_device_id max7762 { .name = "max20024-gpio", }, + {}, }; static struct platform_driver max77620_gpio_driver = {