From patchwork Tue Jun 22 18:30:15 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Basile Starynkevitch X-Patchwork-Id: 56562 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id DCA30B6F11 for ; Wed, 23 Jun 2010 04:31:17 +1000 (EST) Received: (qmail 8239 invoked by alias); 22 Jun 2010 18:31:14 -0000 Received: (qmail 8214 invoked by uid 22791); 22 Jun 2010 18:31:12 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, RCVD_IN_RP_RNBL X-Spam-Check-By: sourceware.org Received: from smtp-102-tuesday.nerim.net (HELO kraid.nerim.net) (62.4.16.102) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Jun 2010 18:31:06 +0000 Received: from hector.lesours (ours.starynkevitch.net [213.41.244.95]) by kraid.nerim.net (Postfix) with ESMTP id 119E9CF17E; Tue, 22 Jun 2010 20:31:03 +0200 (CEST) Received: from glinka.lesours ([192.168.0.1]) by hector.lesours with esmtp (Exim 4.72) (envelope-from ) id 1OR8FT-00006O-DX; Tue, 22 Jun 2010 20:31:03 +0200 Subject: trunk patch: moving gimple_seq_node from coretypes.h to gimple.h From: Basile Starynkevitch Reply-To: basile@starynkevitch.net To: gcc-patches@gcc.gnu.org Cc: "Joseph S.Myers" Date: Tue, 22 Jun 2010 20:30:15 +0200 Message-ID: <1277231415.19557.20.camel@glinka> Mime-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hello All, since gimple_seq_node is not very useful in coretypes.h I bootstrapped the following attached patch to trunk rev.161214 on x86_64-unknown-linux-gnu with c,c++,lto languages. gcc/ChangeLog entry: 2010-06-22 Basile Starynkevitch * coretypes.h (gimple_seq_node_d, gimple_seq_node) (const_gimple_seq_node): Removed typedefs. * gimple.h (gimple_seq_node_d, gimple_seq_node) (const_gimple_seq_node): Added typedefs moved from coretypes.h. See also http://gcc.gnu.org/ml/gcc/2010-06/msg00670.html & http://gcc.gnu.org/ml/gcc/2010-06/msg00657.html By the way, I would also happy if someone could also review the GNU-friendly gengtype patch http://gcc.gnu.org/ml/gcc-patches/2010-06/msg02178.html Cheers Index: gcc/coretypes.h =================================================================== --- gcc/coretypes.h (revision 161214) +++ gcc/coretypes.h (working copy) @@ -68,9 +68,6 @@ struct cl_optimization; struct gimple_seq_d; typedef struct gimple_seq_d *gimple_seq; typedef const struct gimple_seq_d *const_gimple_seq; -struct gimple_seq_node_d; -typedef struct gimple_seq_node_d *gimple_seq_node; -typedef const struct gimple_seq_node_d *const_gimple_seq_node; /* Address space number for named address space support. */ typedef unsigned char addr_space_t; Index: gcc/gimple.h =================================================================== --- gcc/gimple.h (revision 161214) +++ gcc/gimple.h (working copy) @@ -33,6 +33,12 @@ along with GCC; see the file COPYING3. If not see #include "tree-ssa-operands.h" #include "tree-ssa-alias.h" +/* The types gimple & gimple_seq are defined in coretypes.h but + gimple_seq_node is not needed there. */ +struct gimple_seq_node_d; +typedef struct gimple_seq_node_d *gimple_seq_node; +typedef const struct gimple_seq_node_d *const_gimple_seq_node; + /* For each block, the PHI nodes that need to be rewritten are stored into these vectors. */ typedef VEC(gimple, heap) *gimple_vec;