diff mbox

[1/1] package/libldns: Fix build error with target install-manpages

Message ID 1452458817-2184-1-git-send-email-bernd.kuhls@t-online.de
State Changes Requested
Headers show

Commit Message

Bernd Kuhls Jan. 10, 2016, 8:46 p.m. UTC
Using this minimal defconfig

BR2_PACKAGE_LIBLDNS=y

the build fails due to the non-existing directory share/man/man3/

./install-sh: doc/man/man3/* does not exist.
Makefile:297: recipe for target 'install-manpages' failed
make[1]: *** [install-manpages] Error 1

Since we do not need manpages anyway this patch disables the
corresponding make target.

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/libldns/libldns.mk | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Thomas Petazzoni March 22, 2016, 8:41 p.m. UTC | #1
Hello,

On Sun, 10 Jan 2016 21:46:57 +0100, Bernd Kuhls wrote:
> Using this minimal defconfig
> 
> BR2_PACKAGE_LIBLDNS=y
> 
> the build fails due to the non-existing directory share/man/man3/

This is not correct. The target directory share/man/man3 is created by
the install process. Here is what you can see in the build log:

./install-sh  -d /home/thomas/projets/buildroot/output/target/usr/share/man/man3
for f in doc/man/man3/*; do \
	./install-sh  -c -m 444 $f /home/thomas/projets/buildroot/output/target/usr/share/man/man3/; \
done

> ./install-sh: doc/man/man3/* does not exist.
> Makefile:297: recipe for target 'install-manpages' failed
> make[1]: *** [install-manpages] Error 1

It is actually the source directory, doc/man/man3/ that doesn't seem to
exist, or at least that is empty. Its contents are apparently generated
by a Perl script, and Perl is a mandatory dependency of Buildroot.

I've tested a minimal configuration like yours, both on my machine, and
in a limited chroot used in the autobuilders, and I was not able to
reproduce.

So, I'd like to have a better patch that clearly identifies the reason
of the failure.

Thanks!

Thomas
diff mbox

Patch

diff --git a/package/libldns/libldns.mk b/package/libldns/libldns.mk
index 3d4d356..5595407 100644
--- a/package/libldns/libldns.mk
+++ b/package/libldns/libldns.mk
@@ -10,6 +10,12 @@  LIBLDNS_SITE = http://www.nlnetlabs.nl/downloads/ldns
 LIBLDNS_LICENSE = BSD-3c
 LIBLDNS_LICENSE_FILES = LICENSE
 LIBLDNS_INSTALL_STAGING = YES
+
+define LIBLDNS_DISABLE_INSTALL_MANPAGES
+	$(SED) 's/ install-manpages / /' $(@D)/Makefile.in
+endef
+LIBLDNS_POST_PATCH_HOOKS += LIBLDNS_DISABLE_INSTALL_MANPAGES
+
 LIBLDNS_CONF_OPTS = \
 	--without-examples \
 	--without-p5-dns-ldns \