diff mbox

[net-next,1/3] openvswitch: clean up unused function

Message ID 1452380831-11258-2-git-send-email-sakiwit@gmail.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Jεan Sacren Jan. 9, 2016, 11:07 p.m. UTC 
From: Jean Sacren <sakiwit@gmail.com>

commit 6b001e682e90 ("openvswitch: Use Geneve device.")

The commit above deleted the only call site of ovs_tunnel_route_lookup()
and now that function is not used any more. So let's delete the function
definition as well.

Signed-off-by: Jean Sacren <sakiwit@gmail.com>
---
 net/openvswitch/vport.h | 20 --------------------
 1 file changed, 20 deletions(-)

Comments

Thomas Graf Jan. 10, 2016, 10:16 a.m. UTC | #1 
On 01/09/16 at 04:07pm, J??an Sacren wrote:
> From: Jean Sacren <sakiwit@gmail.com>
> 
> commit 6b001e682e90 ("openvswitch: Use Geneve device.")
> 
> The commit above deleted the only call site of ovs_tunnel_route_lookup()
> and now that function is not used any more. So let's delete the function
> definition as well.
> 
> Signed-off-by: Jean Sacren <sakiwit@gmail.com>

Acked-by: Thomas Graf <tgraf@suug.ch>
diff mbox

Patch

diff --git a/net/openvswitch/vport.h b/net/openvswitch/vport.h
index 8ea3a96980ac..f00bb153ad13 100644
--- a/net/openvswitch/vport.h
+++ b/net/openvswitch/vport.h
@@ -204,26 +204,6 @@  int __ovs_vport_ops_register(struct vport_ops *ops);
 	})
 
 void ovs_vport_ops_unregister(struct vport_ops *ops);
-
-static inline struct rtable *ovs_tunnel_route_lookup(struct net *net,
-						     const struct ip_tunnel_key *key,
-						     u32 mark,
-						     struct flowi4 *fl,
-						     u8 protocol)
-{
-	struct rtable *rt;
-
-	memset(fl, 0, sizeof(*fl));
-	fl->daddr = key->u.ipv4.dst;
-	fl->saddr = key->u.ipv4.src;
-	fl->flowi4_tos = RT_TOS(key->tos);
-	fl->flowi4_mark = mark;
-	fl->flowi4_proto = protocol;
-
-	rt = ip_route_output_key(net, fl);
-	return rt;
-}
-
 void ovs_vport_send(struct vport *vport, struct sk_buff *skb);
 
 #endif /* vport.h */