diff mbox

libstdc++/69105, 69106, 69114 use std::addressof

Message ID 20160108131356.GI30323@redhat.com
State New
Headers show

Commit Message

Jonathan Wakely Jan. 8, 2016, 1:13 p.m. UTC
On 07/01/16 15:01 +0000, Jonathan Wakely wrote:
>A bumper crop of addressof bugs where I was using & but should have
>used std::addressof.

This caused a regression, fixed like so.

Tested x86_64-linux, committed to trunk.

Comments

Kyrill Tkachov Jan. 8, 2016, 1:17 p.m. UTC | #1
Hi Jonathan,

On 08/01/16 13:13, Jonathan Wakely wrote:
> On 07/01/16 15:01 +0000, Jonathan Wakely wrote:
>> A bumper crop of addressof bugs where I was using & but should have
>> used std::addressof.
>
> This caused a regression, fixed like so.
>
> Tested x86_64-linux, committed to trunk.
>
>

You used "PR libstdc++/69160" in your changelog so the commit got logged
to the unrelated PR tree-optimization/69160 instead

Kyrill
Jonathan Wakely Jan. 8, 2016, 1:21 p.m. UTC | #2
On 08/01/16 13:17 +0000, Kyrill Tkachov wrote:
>Hi Jonathan,
>
>On 08/01/16 13:13, Jonathan Wakely wrote:
>>On 07/01/16 15:01 +0000, Jonathan Wakely wrote:
>>>A bumper crop of addressof bugs where I was using & but should have
>>>used std::addressof.
>>
>>This caused a regression, fixed like so.
>>
>>Tested x86_64-linux, committed to trunk.
>>
>>
>
>You used "PR libstdc++/69160" in your changelog so the commit got logged
>to the unrelated PR tree-optimization/69160 instead

Yeah, I realised when the commit didn't show up in the 69190 comments
:-\

I've fixed the ChangeLog in the next commit, thanks for spotting it.
diff mbox

Patch

commit 8f7a4cbf1cdae97578a6b4236af532879be15e9d
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Fri Jan 8 12:05:44 2016 +0000

    Add missing include for std::__addressof
    
    	PR libstdc++/69160
    	* include/bits/uses_allocator.h: Add missing include.

diff --git a/libstdc++-v3/include/bits/uses_allocator.h b/libstdc++-v3/include/bits/uses_allocator.h
index b3c3f60..70ba007 100644
--- a/libstdc++-v3/include/bits/uses_allocator.h
+++ b/libstdc++-v3/include/bits/uses_allocator.h
@@ -30,6 +30,7 @@ 
 #else
 
 #include <type_traits>
+#include <bits/move.h>
 
 namespace std _GLIBCXX_VISIBILITY(default)
 {