diff mbox

[2/2] bfin_mac: fix error path

Message ID 1452252495-20961-2-git-send-email-sudipm.mukherjee@gmail.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Sudip Mukherjee Jan. 8, 2016, 11:28 a.m. UTC
While building blackfin defconfig we were getting a build warning:
warning: label 'out_err_irq_alloc' defined but not used.

Commit e7f4dc3536a4 ("mdio: Move allocation of interrupts into core")
removed the label out_err_mdiobus_register but then mistakenly jumped to
out_err_alloc. But it was actually supposed to jump to out_err_irq_alloc.

Fixes: e7f4dc3536a4 ("mdio: Move allocation of interrupts into core")
Cc: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/net/ethernet/adi/bfin_mac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller Jan. 11, 2016, 3:46 a.m. UTC | #1
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: Fri,  8 Jan 2016 16:58:15 +0530

> While building blackfin defconfig we were getting a build warning:
> warning: label 'out_err_irq_alloc' defined but not used.
> 
> Commit e7f4dc3536a4 ("mdio: Move allocation of interrupts into core")
> removed the label out_err_mdiobus_register but then mistakenly jumped to
> out_err_alloc. But it was actually supposed to jump to out_err_irq_alloc.
> 
> Fixes: e7f4dc3536a4 ("mdio: Move allocation of interrupts into core")
> Cc: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>

Applied.
diff mbox

Patch

diff --git a/drivers/net/ethernet/adi/bfin_mac.c b/drivers/net/ethernet/adi/bfin_mac.c
index 6f3432a..5ddfd0e 100644
--- a/drivers/net/ethernet/adi/bfin_mac.c
+++ b/drivers/net/ethernet/adi/bfin_mac.c
@@ -1857,7 +1857,7 @@  static int bfin_mii_bus_probe(struct platform_device *pdev)
 	rc = mdiobus_register(miibus);
 	if (rc) {
 		dev_err(&pdev->dev, "Cannot register MDIO bus!\n");
-		goto out_err_alloc;
+		goto out_err_irq_alloc;
 	}
 
 	platform_set_drvdata(pdev, miibus);