diff mbox

[3/6] QE: Add uqe_serial document to bindings

Message ID 1452219494-31947-3-git-send-email-qiang.zhao@nxp.com (mailing list archive)
State Superseded
Headers show

Commit Message

Qiang Zhao Jan. 8, 2016, 2:18 a.m. UTC 
Add uqe_serial document to
Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt

Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
 .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt       | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt

Comments

Rob Herring Jan. 8, 2016, 8:12 p.m. UTC | #1 
On Fri, Jan 08, 2016 at 10:18:11AM +0800, Zhao Qiang wrote:
> Add uqe_serial document to
> Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> 
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
>  .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt       | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> 
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> new file mode 100644
> index 0000000..e677599
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> @@ -0,0 +1,20 @@
> +* Serial
> +
> +Currently defined compatibles:
> +- ucc_uart
> +
> +Properties for ucc_uart:
> +device_type : which type the device is

Drop this please.

> +port-number : port number of UCC-UART

Use aliases instead.

> +rx-clock-name : which clock QE use for RX
> +tx-clock-name : which clock QE use for TX

These should use the clock binding.

> +
> +Example:
> +
> +	serial: ucc@2200 {
> +		device_type = "serial";
> +		compatible = "ucc_uart";
> +		port-number = <1>;
> +		rx-clock-name = "brg2";
> +		tx-clock-name = "brg2";
> +	};
> -- 
> 2.1.0.27.g96db324
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Qiang Zhao Jan. 11, 2016, 8:19 a.m. UTC | #2 
On Fri, Jan 09, 2016 at 04:12AM, Rob Herring <robh@kernel.org> wrote:
> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: Saturday, January 09, 2016 4:12 AM
> To: Qiang Zhao <qiang.zhao@nxp.com>
> Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linuxppc-
> dev@lists.ozlabs.org; Priyanka.Jain@freescale.com; oss@buserror.net
> Subject: Re: [PATCH 3/6] QE: Add uqe_serial document to bindings
> 
> On Fri, Jan 08, 2016 at 10:18:11AM +0800, Zhao Qiang wrote:
> > Add uqe_serial document to
> > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> >
> > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > ---
> >  .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt       | 20
> ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > new file mode 100644
> > index 0000000..e677599
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.
> > +++ txt
> > @@ -0,0 +1,20 @@
> > +* Serial
> > +
> > +Currently defined compatibles:
> > +- ucc_uart
> > +
> > +Properties for ucc_uart:
> > +device_type : which type the device is
> 
> Drop this please.

Yes, I will drop it in next version.

> 
> > +port-number : port number of UCC-UART
> 
> Use aliases instead.

I don't understand, can you explain more?

> 
> > +rx-clock-name : which clock QE use for RX tx-clock-name : which clock
> > +QE use for TX
> 
> These should use the clock binding.

This property means which clock source the UCC use, 
the QE just use this property to route UCC clock to clock source.
The clock source maybe either internal or outside(from clock input pin).
So clock binding is not apply in this case.

> 
> > +
> > +Example:
> > +
> > +	serial: ucc@2200 {
> > +		device_type = "serial";
> > +		compatible = "ucc_uart";
> > +		port-number = <1>;
> > +		rx-clock-name = "brg2";
> > +		tx-clock-name = "brg2";
> > +	};
> > --
> > 2.1.0.27.g96db324
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe devicetree"
> > in the body of a message to majordomo@vger.kernel.org More majordomo
> > info at  http://vger.kernel.org/majordomo-info.html
Best Regards
Zhao Qiang
Qiang Zhao Jan. 18, 2016, 3:28 a.m. UTC | #3 
Hi Rob,

Please, is there any update regarding of my question?
Thank you!

Best Regards
Zhao Qiang

> -----Original Message-----
> From: Qiang Zhao
> Sent: Monday, January 11, 2016 4:19 PM
> To: 'Rob Herring' <robh@kernel.org>
> Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linuxppc-
> dev@lists.ozlabs.org; Priyanka.Jain@freescale.com; oss@buserror.net
> Subject: RE: [PATCH 3/6] QE: Add uqe_serial document to bindings
> 
> On Fri, Jan 09, 2016 at 04:12AM, Rob Herring <robh@kernel.org> wrote:
> > -----Original Message-----
> > From: Rob Herring [mailto:robh@kernel.org]
> > Sent: Saturday, January 09, 2016 4:12 AM
> > To: Qiang Zhao <qiang.zhao@nxp.com>
> > Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> > linuxppc- dev@lists.ozlabs.org; Priyanka.Jain@freescale.com;
> > oss@buserror.net
> > Subject: Re: [PATCH 3/6] QE: Add uqe_serial document to bindings
> >
> > On Fri, Jan 08, 2016 at 10:18:11AM +0800, Zhao Qiang wrote:
> > > Add uqe_serial document to
> > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > >
> > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > > ---
> > >  .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt       | 20
> > ++++++++++++++++++++
> > >  1 file changed, 20 insertions(+)
> > >  create mode 100644
> > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.tx
> > > t
> > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.tx
> > > t
> > > new file mode 100644
> > > index 0000000..e677599
> > > --- /dev/null
> > > +++
> b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.
> > > +++ txt
> > > @@ -0,0 +1,20 @@
> > > +* Serial
> > > +
> > > +Currently defined compatibles:
> > > +- ucc_uart
> > > +
> > > +Properties for ucc_uart:
> > > +device_type : which type the device is
> >
> > Drop this please.
> 
> Yes, I will drop it in next version.
> 
> >
> > > +port-number : port number of UCC-UART
> >
> > Use aliases instead.
> 
> I don't understand, can you explain more?
> 
> >
> > > +rx-clock-name : which clock QE use for RX tx-clock-name : which
> > > +clock QE use for TX
> >
> > These should use the clock binding.
> 
> This property means which clock source the UCC use, the QE just use this
> property to route UCC clock to clock source.
> The clock source maybe either internal or outside(from clock input pin).
> So clock binding is not apply in this case.
> 
> >
> > > +
> > > +Example:
> > > +
> > > +	serial: ucc@2200 {
> > > +		device_type = "serial";
> > > +		compatible = "ucc_uart";
> > > +		port-number = <1>;
> > > +		rx-clock-name = "brg2";
> > > +		tx-clock-name = "brg2";
> > > +	};
> > > --
> > > 2.1.0.27.g96db324
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe devicetree"
> > > in the body of a message to majordomo@vger.kernel.org More
> majordomo
> > > info at  http://vger.kernel.org/majordomo-info.html
> Best Regards
> Zhao Qiang
Yang Li Jan. 18, 2016, 9:10 a.m. UTC | #4 
On Fri, Jan 8, 2016 at 10:18 AM, Zhao Qiang <qiang.zhao@nxp.com> wrote:
> Add uqe_serial document to
> Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt

As you have submitted patch to move QE code from arch/powerpc into
drivers/soc/fsl for the reuse of ARM and powerpc,  you should also
move the binding documents out of the powerpc folder into a more
common place and add new bindings in the new location.

Regards,
Leo
Qiang Zhao Jan. 18, 2016, 9:24 a.m. UTC | #5 
On Fri, Jan 18, 2016 at 05:10 PM, Li Yang <leoli@freescale.com>wrote:
> -----Original Message-----

> From: pku.leo@gmail.com [mailto:pku.leo@gmail.com] On Behalf Of Li Yang

> Sent: Monday, January 18, 2016 5:10 PM

> To: Qiang Zhao <qiang.zhao@nxp.com>

> Cc: devicetree@vger.kernel.org; lkml <linux-kernel@vger.kernel.org>;

> linuxppc-dev <linuxppc-dev@lists.ozlabs.org>; Priyanka.Jain@freescale.com;

> oss@buserror.net

> Subject: Re: [PATCH 3/6] QE: Add uqe_serial document to bindings

> 

> On Fri, Jan 8, 2016 at 10:18 AM, Zhao Qiang <qiang.zhao@nxp.com> wrote:

> > Add uqe_serial document to

> > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt

> 

> As you have submitted patch to move QE code from arch/powerpc into

> drivers/soc/fsl for the reuse of ARM and powerpc,  you should also move the

> binding documents out of the powerpc folder into a more common place and

> add new bindings in the new location.


Thank you for your recommendation. 
How about create a new directory named qe under "Documentation/devicetree/bindings/"? 
Or you have a better suggestion?

Regards 
-Zhao Qiang
Crystal Wood Jan. 18, 2016, 11:07 p.m. UTC | #6 
On Mon, 2016-01-18 at 09:24 +0000, Qiang Zhao wrote:
> On Fri, Jan 18, 2016 at 05:10 PM, Li Yang <leoli@freescale.com>wrote:
> > -----Original Message-----
> > From: pku.leo@gmail.com [mailto:pku.leo@gmail.com] On Behalf Of Li Yang
> > Sent: Monday, January 18, 2016 5:10 PM
> > To: Qiang Zhao <qiang.zhao@nxp.com>
> > Cc: devicetree@vger.kernel.org; lkml <linux-kernel@vger.kernel.org>;
> > linuxppc-dev <linuxppc-dev@lists.ozlabs.org>; Priyanka.Jain@freescale.com;
> > oss@buserror.net
> > Subject: Re: [PATCH 3/6] QE: Add uqe_serial document to bindings
> > 
> > On Fri, Jan 8, 2016 at 10:18 AM, Zhao Qiang <qiang.zhao@nxp.com> wrote:
> > > Add uqe_serial document to
> > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > 
> > As you have submitted patch to move QE code from arch/powerpc into
> > drivers/soc/fsl for the reuse of ARM and powerpc,  you should also move
> > the
> > binding documents out of the powerpc folder into a more common place and
> > add new bindings in the new location.
> 
> Thank you for your recommendation. 
> How about create a new directory named qe under
> "Documentation/devicetree/bindings/"? 
> Or you have a better suggestion?

Documentation/devicetree/bindings/soc/fsl/cpm_qe

-Scott
Qiang Zhao Jan. 19, 2016, 1:22 a.m. UTC | #7 
On Fri, Jan 19, 2016 at 07:08 PM, Scott Wood <oss@buserror.net> wrote:
> -----Original Message-----

> From: Scott Wood [mailto:oss@buserror.net]

> Sent: Tuesday, January 19, 2016 7:08 AM

> To: Qiang Zhao <qiang.zhao@nxp.com>; Li Yang <leoli@freescale.com>

> Cc: devicetree@vger.kernel.org; lkml <linux-kernel@vger.kernel.org>;

> linuxppc-dev <linuxppc-dev@lists.ozlabs.org>; Priyanka.Jain@freescale.com

> Subject: Re: [PATCH 3/6] QE: Add uqe_serial document to bindings

> 

> On Mon, 2016-01-18 at 09:24 +0000, Qiang Zhao wrote:

> > On Fri, Jan 18, 2016 at 05:10 PM, Li Yang <leoli@freescale.com>wrote:

> > > -----Original Message-----

> > > From: pku.leo@gmail.com [mailto:pku.leo@gmail.com] On Behalf Of Li

> > > Yang

> > > Sent: Monday, January 18, 2016 5:10 PM

> > > To: Qiang Zhao <qiang.zhao@nxp.com>

> > > Cc: devicetree@vger.kernel.org; lkml <linux-kernel@vger.kernel.org>;

> > > linuxppc-dev <linuxppc-dev@lists.ozlabs.org>;

> > > Priyanka.Jain@freescale.com; oss@buserror.net

> > > Subject: Re: [PATCH 3/6] QE: Add uqe_serial document to bindings

> > >

> > > On Fri, Jan 8, 2016 at 10:18 AM, Zhao Qiang <qiang.zhao@nxp.com> wrote:

> > > > Add uqe_serial document to

> > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.tx

> > > > t

> > >

> > > As you have submitted patch to move QE code from arch/powerpc into

> > > drivers/soc/fsl for the reuse of ARM and powerpc,  you should also

> > > move the binding documents out of the powerpc folder into a more

> > > common place and add new bindings in the new location.

> >

> > Thank you for your recommendation.

> > How about create a new directory named qe under

> > "Documentation/devicetree/bindings/"?

> > Or you have a better suggestion?

> 

> Documentation/devicetree/bindings/soc/fsl/cpm_qe


Thank you very much!

Best Regards
Zhao Qiang
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
new file mode 100644
index 0000000..e677599
--- /dev/null
+++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
@@ -0,0 +1,20 @@ 
+* Serial
+
+Currently defined compatibles:
+- ucc_uart
+
+Properties for ucc_uart:
+device_type : which type the device is
+port-number : port number of UCC-UART
+rx-clock-name : which clock QE use for RX
+tx-clock-name : which clock QE use for TX
+
+Example:
+
+	serial: ucc@2200 {
+		device_type = "serial";
+		compatible = "ucc_uart";
+		port-number = <1>;
+		rx-clock-name = "brg2";
+		tx-clock-name = "brg2";
+	};