From patchwork Tue Jun 22 09:09:03 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wan ZongShun X-Patchwork-Id: 56435 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-pw0-f56.google.com (mail-pw0-f56.google.com [209.85.160.56]) by ozlabs.org (Postfix) with ESMTP id B8268B6EF1 for ; Tue, 22 Jun 2010 19:09:21 +1000 (EST) Received: by pwi5 with SMTP id 5sf966068pwi.11 for ; Tue, 22 Jun 2010 02:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:x-beenthere:received:received:received :received:received-spf:received:received:received:message-id:date :from:user-agent:mime-version:to:subject:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; bh=sy2eNNt+wFide8ITDqf4dtQkzRm8ytrUKE0TIMruujM=; b=Dw57VSdxrKMqhtR6UFznUo/CX7d2M7+LNnSb0nJPTtsT2CJxAP55y8pRMsQGmHJG6X xPXNAVBti8w1ahP3vrakARQvjid7eLqwvjosL+rTCwvncQBBGzIn2EwQC4LNo6hYJNnA e8ZnMXmrlc68Aagv2/fLnBCjAGQ1nKMXDJUcw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:message-id:date:from:user-agent :mime-version:to:subject:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; b=Hd8IgSUdD7UOUC+myLLuNN0P3zRE1RIvZ5Bu/fi0GIOyxLiH1t4W4bDpTja7z3JRAU FYkQKiL9iMPjrMD1/IQEztOXfUyNoO2vSpvVquQdUR/PEh0DjmZWC2gIxMFL6CWDdUFp REK17gpyTuyW8s2ToUjDaa0c5j1yiFIt4Wm/w= Received: by 10.115.100.14 with SMTP id c14mr469454wam.9.1277197756337; Tue, 22 Jun 2010 02:09:16 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.115.103.33 with SMTP id f33ls3144564wam.3.p; Tue, 22 Jun 2010 02:09:15 -0700 (PDT) Received: by 10.114.33.39 with SMTP id g39mr1049764wag.1.1277197755731; Tue, 22 Jun 2010 02:09:15 -0700 (PDT) Received: by 10.114.33.39 with SMTP id g39mr1049763wag.1.1277197755718; Tue, 22 Jun 2010 02:09:15 -0700 (PDT) Received: from mail-px0-f180.google.com (mail-px0-f180.google.com [209.85.212.180]) by gmr-mx.google.com with ESMTP id r8si29688619waj.5.2010.06.22.02.09.14; Tue, 22 Jun 2010 02:09:14 -0700 (PDT) Received-SPF: pass (google.com: domain of mcuos.com@gmail.com designates 209.85.212.180 as permitted sender) client-ip=209.85.212.180; Received: by pxi20 with SMTP id 20so583889pxi.11 for ; Tue, 22 Jun 2010 02:09:14 -0700 (PDT) Received: by 10.142.248.40 with SMTP id v40mr4666836wfh.92.1277197754505; Tue, 22 Jun 2010 02:09:14 -0700 (PDT) Received: from [192.168.1.10] ([116.226.201.224]) by mx.google.com with ESMTPS id i19sm2231617rvn.23.2010.06.22.02.09.09 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 22 Jun 2010 02:09:13 -0700 (PDT) Message-ID: <4C207DAF.7010200@gmail.com> Date: Tue, 22 Jun 2010 17:09:03 +0800 From: Wan ZongShun User-Agent: Thunderbird 2.0.0.24 (X11/20100411) MIME-Version: 1.0 To: Alessandro Zummo , Andrew Morton , rtc-linux , LKML , dale@farnsworth.org Subject: [rtc-linux] [PATCH] RTC/max6900: use rtc_valid_tm to check returning tm for max6900 X-Original-Sender: mcuos.com@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of mcuos.com@gmail.com designates 209.85.212.180 as permitted sender) smtp.mail=mcuos.com@gmail.com; dkim=pass (test mode) header.i=@gmail.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Use rtc_valid_tm to check returning tm for max6900, it can avoid returning wrong tm value. Signed-off-by: Wan ZongShun --- drivers/rtc/rtc-max6900.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/rtc/rtc-max6900.c b/drivers/rtc/rtc-max6900.c index a4f6665..486142c 100644 --- a/drivers/rtc/rtc-max6900.c +++ b/drivers/rtc/rtc-max6900.c @@ -159,7 +159,7 @@ static int max6900_i2c_read_time(struct i2c_client *client, struct rtc_time *tm) bcd2bin(regs[MAX6900_REG_CENTURY]) * 100 - 1900; tm->tm_wday = bcd2bin(regs[MAX6900_REG_DW]); - return 0; + return rtc_valid_tm(tm); } static int max6900_i2c_clear_write_protect(struct i2c_client *client)