From patchwork Tue Jun 22 08:57:09 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: frank.blaschka@de.ibm.com X-Patchwork-Id: 56421 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3E206B6EED for ; Tue, 22 Jun 2010 18:58:35 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758967Ab0FVI6R (ORCPT ); Tue, 22 Jun 2010 04:58:17 -0400 Received: from mtagate2.de.ibm.com ([195.212.17.162]:42729 "EHLO mtagate2.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758963Ab0FVI6K (ORCPT ); Tue, 22 Jun 2010 04:58:10 -0400 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate2.de.ibm.com (8.13.1/8.13.1) with ESMTP id o5M8w8G0004413; Tue, 22 Jun 2010 08:58:08 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o5M8w8E01093682; Tue, 22 Jun 2010 10:58:08 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o5M8w8HY022614; Tue, 22 Jun 2010 10:58:08 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id o5M8w8gq022609; Tue, 22 Jun 2010 10:58:08 +0200 Received: by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 24631) id 0B9F7122422C; Tue, 22 Jun 2010 10:58:08 +0200 (CEST) Message-Id: <20100622085807.926487000@de.ibm.com> User-Agent: quilt/0.47-1 Date: Tue, 22 Jun 2010 10:57:09 +0200 From: frank.blaschka@de.ibm.com To: davem@davemloft.net Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org, Carsten Otte Subject: [patch 08/11] [PATCH] qeth: fix use after free for qeths debug area References: <20100622085701.772508000@de.ibm.com> Content-Disposition: inline; filename=608-qeth-debug-area-free.diff Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Carsten Otte The function qeth_free_buffer_pool is called _after_ the per-card debug area has been released. This debug message is not all that usefull anyway, and thus gets removed. Signed-off-by: Carsten Otte Signed-off-by: Frank Blaschka --- drivers/s390/net/qeth_core_main.c | 1 - 1 file changed, 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -urpN linux-2.6/drivers/s390/net/qeth_core_main.c linux-2.6-patched/drivers/s390/net/qeth_core_main.c --- linux-2.6/drivers/s390/net/qeth_core_main.c 2010-06-22 08:55:01.000000000 +0200 +++ linux-2.6-patched/drivers/s390/net/qeth_core_main.c 2010-06-22 08:55:01.000000000 +0200 @@ -973,7 +973,6 @@ static void qeth_free_buffer_pool(struct { struct qeth_buffer_pool_entry *pool_entry, *tmp; int i = 0; - QETH_CARD_TEXT(card, 5, "freepool"); list_for_each_entry_safe(pool_entry, tmp, &card->qdio.init_pool.entry_list, init_list){ for (i = 0; i < QETH_MAX_BUFFER_ELEMENTS(card); ++i)