| Message ID | 1452084792-17424-1-git-send-email-drjones@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 01/06/2016 05:53 AM, Andrew Jones wrote: > stream_desc_show() (and DEBUG_ENET) appear to be unused, as the > function isn't compilable (there are broken PRI format strings). > > Signed-off-by: Andrew Jones <drjones@redhat.com> > --- > hw/dma/xilinx_axidma.c | 10 ---------- > 1 file changed, 10 deletions(-) Reviewed-by: Eric Blake <eblake@redhat.com>
On Wed, Jan 6, 2016 at 7:54 AM, Eric Blake <eblake@redhat.com> wrote: > On 01/06/2016 05:53 AM, Andrew Jones wrote: >> stream_desc_show() (and DEBUG_ENET) appear to be unused, as the >> function isn't compilable (there are broken PRI format strings). >> >> Signed-off-by: Andrew Jones <drjones@redhat.com> >> --- >> hw/dma/xilinx_axidma.c | 10 ---------- >> 1 file changed, 10 deletions(-) > > Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Alistair Francis <alistair.francis@xilinx.com> Thanks, Alistair > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >
On 6 January 2016 at 12:53, Andrew Jones <drjones@redhat.com> wrote: > stream_desc_show() (and DEBUG_ENET) appear to be unused, as the > function isn't compilable (there are broken PRI format strings). > > Signed-off-by: Andrew Jones <drjones@redhat.com> > --- > hw/dma/xilinx_axidma.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c > index b1cfa11356a26..f5ebc1f0e0734 100644 > --- a/hw/dma/xilinx_axidma.c > +++ b/hw/dma/xilinx_axidma.c > @@ -177,16 +177,6 @@ static inline int streamid_from_addr(hwaddr addr) > return sid; > } > > -#ifdef DEBUG_ENET > -static void stream_desc_show(struct SDesc *d) > -{ > - qemu_log("buffer_addr = " PRIx64 "\n", d->buffer_address); > - qemu_log("nxtdesc = " PRIx64 "\n", d->nxtdesc); > - qemu_log("control = %x\n", d->control); > - qemu_log("status = %x\n", d->status); > -} > -#endif > - > static void stream_desc_load(struct Stream *s, hwaddr addr) > { > struct SDesc *d = &s->desc; Applied to target-arm.next, thanks. -- PMM
diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c index b1cfa11356a26..f5ebc1f0e0734 100644 --- a/hw/dma/xilinx_axidma.c +++ b/hw/dma/xilinx_axidma.c @@ -177,16 +177,6 @@ static inline int streamid_from_addr(hwaddr addr) return sid; } -#ifdef DEBUG_ENET -static void stream_desc_show(struct SDesc *d) -{ - qemu_log("buffer_addr = " PRIx64 "\n", d->buffer_address); - qemu_log("nxtdesc = " PRIx64 "\n", d->nxtdesc); - qemu_log("control = %x\n", d->control); - qemu_log("status = %x\n", d->status); -} -#endif - static void stream_desc_load(struct Stream *s, hwaddr addr) { struct SDesc *d = &s->desc;
stream_desc_show() (and DEBUG_ENET) appear to be unused, as the function isn't compilable (there are broken PRI format strings). Signed-off-by: Andrew Jones <drjones@redhat.com> --- hw/dma/xilinx_axidma.c | 10 ---------- 1 file changed, 10 deletions(-)