| Message ID | 1452056418-14812-1-git-send-email-prabhakar@freescale.com |
|---|---|
| State | Accepted |
| Commit | 40b8a3db833294bb1bc116592fad52667bc39680 |
| Delegated to: | York Sun |
| Headers | show |
On 01/05/2016 09:00 PM, Prabhakar Kushwaha wrote: > kernel_size env variable is defined as 0x28000000, it is beyond NOR > flash. > > Update kernel_size with 40MB kernel size. > > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> > --- > include/configs/ls2080aqds.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/configs/ls2080aqds.h b/include/configs/ls2080aqds.h > index ba84248..a402c06 100644 > --- a/include/configs/ls2080aqds.h > +++ b/include/configs/ls2080aqds.h > @@ -346,7 +346,7 @@ unsigned long get_board_ddr_clk(void); > "initrd_high=0xffffffffffffffff\0" \ > "kernel_start=0x581100000\0" \ > "kernel_load=0xa0000000\0" \ > - "kernel_size=0x28000000\0" > + "kernel_size=0x2800000\0" > > #ifdef CONFIG_FSL_MC_ENET > #define CONFIG_FSL_MEMAC > Prabhakar, I am tired of these changes. Can you go over all the default settings and verify they all make sense? A short while ago Scott found fdt_high was not correct. York
> -----Original Message----- > From: york sun [mailto:york.sun@nxp.com] > Sent: Thursday, January 14, 2016 11:37 PM > To: Prabhakar Kushwaha <prabhakar@freescale.com>; u-boot@lists.denx.de > Cc: Scott Wood <oss@buserror.net> > Subject: Re: [PATCH] board: ls2085aqds: Update kernel_size env variable > > On 01/05/2016 09:00 PM, Prabhakar Kushwaha wrote: > > kernel_size env variable is defined as 0x28000000, it is beyond NOR > > flash. > > > > Update kernel_size with 40MB kernel size. > > > > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> > > --- > > include/configs/ls2080aqds.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/configs/ls2080aqds.h > > b/include/configs/ls2080aqds.h index ba84248..a402c06 100644 > > --- a/include/configs/ls2080aqds.h > > +++ b/include/configs/ls2080aqds.h > > @@ -346,7 +346,7 @@ unsigned long get_board_ddr_clk(void); > > "initrd_high=0xffffffffffffffff\0" \ > > "kernel_start=0x581100000\0" \ > > "kernel_load=0xa0000000\0" \ > > - "kernel_size=0x28000000\0" > > + "kernel_size=0x2800000\0" > > > > #ifdef CONFIG_FSL_MC_ENET > > #define CONFIG_FSL_MEMAC > > > Prabhakar, > > I am tired of these changes. Can you go over all the default settings and > verify they all make sense? I agree. Let me review all settings and provide one patch to fix all of them at once. Do you want to hold this patch till I check and provide patch (if required) >A short while ago Scott found fdt_high was not correct. Is this change part of code or not? --prabhakar
On Thu, 2016-01-14 at 18:06 +0000, york sun wrote: > On 01/05/2016 09:00 PM, Prabhakar Kushwaha wrote: > > kernel_size env variable is defined as 0x28000000, it is beyond NOR > > flash. > > > > Update kernel_size with 40MB kernel size. > > > > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> > > --- > > include/configs/ls2080aqds.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/configs/ls2080aqds.h b/include/configs/ls2080aqds.h > > index ba84248..a402c06 100644 > > --- a/include/configs/ls2080aqds.h > > +++ b/include/configs/ls2080aqds.h > > @@ -346,7 +346,7 @@ unsigned long get_board_ddr_clk(void); > > "initrd_high=0xffffffffffffffff\0" \ > > "kernel_start=0x581100000\0" \ > > "kernel_load=0xa0000000\0" \ > > - "kernel_size=0x28000000\0" > > + "kernel_size=0x2800000\0" > > > > #ifdef CONFIG_FSL_MC_ENET > > #define CONFIG_FSL_MEMAC > > > Prabhakar, > > I am tired of these changes. Can you go over all the default settings and > verify > they all make sense? A short while ago Scott found fdt_high was not correct. That was ls1021a. -Scott
On 01/14/2016 08:53 PM, Prabhakar Kushwaha wrote: > >> -----Original Message----- >> From: york sun [mailto:york.sun@nxp.com] >> Sent: Thursday, January 14, 2016 11:37 PM >> To: Prabhakar Kushwaha <prabhakar@freescale.com>; u-boot@lists.denx.de >> Cc: Scott Wood <oss@buserror.net> >> Subject: Re: [PATCH] board: ls2085aqds: Update kernel_size env variable >> >> On 01/05/2016 09:00 PM, Prabhakar Kushwaha wrote: >>> kernel_size env variable is defined as 0x28000000, it is beyond NOR >>> flash. >>> >>> Update kernel_size with 40MB kernel size. >>> >>> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> >>> --- >>> include/configs/ls2080aqds.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/include/configs/ls2080aqds.h >>> b/include/configs/ls2080aqds.h index ba84248..a402c06 100644 >>> --- a/include/configs/ls2080aqds.h >>> +++ b/include/configs/ls2080aqds.h >>> @@ -346,7 +346,7 @@ unsigned long get_board_ddr_clk(void); >>> "initrd_high=0xffffffffffffffff\0" \ >>> "kernel_start=0x581100000\0" \ >>> "kernel_load=0xa0000000\0" \ >>> - "kernel_size=0x28000000\0" >>> + "kernel_size=0x2800000\0" >>> >>> #ifdef CONFIG_FSL_MC_ENET >>> #define CONFIG_FSL_MEMAC >>> >> Prabhakar, >> >> I am tired of these changes. Can you go over all the default settings and >> verify they all make sense? > > I agree. > > Let me review all settings and provide one patch to fix all of them at once. > Do you want to hold this patch till I check and provide patch (if required) > >> A short while ago Scott found fdt_high was not correct. > > Is this change part of code or not? > Prabhakar, Do you have update on this patch? York
> -----Original Message----- > From: york sun > Sent: Wednesday, January 27, 2016 11:09 PM > To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; u- > boot@lists.denx.de > Cc: Scott Wood <oss@buserror.net> > Subject: Re: [PATCH] board: ls2085aqds: Update kernel_size env variable > > On 01/14/2016 08:53 PM, Prabhakar Kushwaha wrote: > > > >> -----Original Message----- > >> From: york sun [mailto:york.sun@nxp.com] > >> Sent: Thursday, January 14, 2016 11:37 PM > >> To: Prabhakar Kushwaha <prabhakar@freescale.com>; > >> u-boot@lists.denx.de > >> Cc: Scott Wood <oss@buserror.net> > >> Subject: Re: [PATCH] board: ls2085aqds: Update kernel_size env > >> variable > >> > >> On 01/05/2016 09:00 PM, Prabhakar Kushwaha wrote: > >>> kernel_size env variable is defined as 0x28000000, it is beyond NOR > >>> flash. > >>> > >>> Update kernel_size with 40MB kernel size. > >>> > >>> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> > >>> --- > >>> include/configs/ls2080aqds.h | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/include/configs/ls2080aqds.h > >>> b/include/configs/ls2080aqds.h index ba84248..a402c06 100644 > >>> --- a/include/configs/ls2080aqds.h > >>> +++ b/include/configs/ls2080aqds.h > >>> @@ -346,7 +346,7 @@ unsigned long get_board_ddr_clk(void); > >>> "initrd_high=0xffffffffffffffff\0" \ > >>> "kernel_start=0x581100000\0" \ > >>> "kernel_load=0xa0000000\0" \ > >>> - "kernel_size=0x28000000\0" > >>> + "kernel_size=0x2800000\0" > >>> > >>> #ifdef CONFIG_FSL_MC_ENET > >>> #define CONFIG_FSL_MEMAC > >>> > >> Prabhakar, > >> > >> I am tired of these changes. Can you go over all the default settings > >> and verify they all make sense? > > > > I agree. > > > > Let me review all settings and provide one patch to fix all of them at once. > > Do you want to hold this patch till I check and provide patch (if > > required) > > > >> A short while ago Scott found fdt_high was not correct. > > > > Is this change part of code or not? > > > > Prabhakar, > > Do you have update on this patch? > I compared both QDS and RDB configuration files. They will be equal after merger of this patch. No patch update is required. --prabhakar
On 01/05/2016 09:00 PM, Prabhakar Kushwaha wrote: > kernel_size env variable is defined as 0x28000000, it is beyond NOR > flash. > > Update kernel_size with 40MB kernel size. > > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> > --- Applied to u-boot-fsl-qoriq master branch. Awaiting upstream. Thanks. York
diff --git a/include/configs/ls2080aqds.h b/include/configs/ls2080aqds.h index ba84248..a402c06 100644 --- a/include/configs/ls2080aqds.h +++ b/include/configs/ls2080aqds.h @@ -346,7 +346,7 @@ unsigned long get_board_ddr_clk(void); "initrd_high=0xffffffffffffffff\0" \ "kernel_start=0x581100000\0" \ "kernel_load=0xa0000000\0" \ - "kernel_size=0x28000000\0" + "kernel_size=0x2800000\0" #ifdef CONFIG_FSL_MC_ENET #define CONFIG_FSL_MEMAC
kernel_size env variable is defined as 0x28000000, it is beyond NOR flash. Update kernel_size with 40MB kernel size. Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> --- include/configs/ls2080aqds.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)