| Message ID | 1277157733-14071-1-git-send-email-justinmattock@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, Jun 21, 2010 at 03:02:13PM -0700, Justin P. Mattock wrote: > This is a resend from version one due to trying a different approach > than the original(probably important to leave netdev_priv() in). > > In any case have a look, if there's another approach let me know > and ill test it out. The below patch fixes a warning im seeing > when compiling with gcc 4.6.0 > > CC [M] drivers/net/wireless/hostap/hostap_main.o > drivers/net/wireless/hostap/hostap_main.c: In function 'hostap_set_multicast_list_queue': > drivers/net/wireless/hostap/hostap_main.c:744:27: warning: variable 'iface' set but not used > Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> I already applied the other version to wireless-next-2.6. I can't imagine what you mean to accomplish by leaving in a call to netdev_priv w/o assigning the result to something. John
On 06/22/2010 11:13 AM, John W. Linville wrote: > On Mon, Jun 21, 2010 at 03:02:13PM -0700, Justin P. Mattock wrote: >> This is a resend from version one due to trying a different approach >> than the original(probably important to leave netdev_priv() in). >> >> In any case have a look, if there's another approach let me know >> and ill test it out. The below patch fixes a warning im seeing >> when compiling with gcc 4.6.0 >> >> CC [M] drivers/net/wireless/hostap/hostap_main.o >> drivers/net/wireless/hostap/hostap_main.c: In function 'hostap_set_multicast_list_queue': >> drivers/net/wireless/hostap/hostap_main.c:744:27: warning: variable 'iface' set but not used >> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com> > > I already applied the other version to wireless-next-2.6. I can't > imagine what you mean to accomplish by leaving in a call to netdev_priv > w/o assigning the result to something. > > John alright.. as for the netdev_priv, I was getting confused on this one. Thanks for taking the time to look at this. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/hostap/hostap_main.c b/drivers/net/wireless/hostap/hostap_main.c index eb57d1e..a866e7a 100644 --- a/drivers/net/wireless/hostap/hostap_main.c +++ b/drivers/net/wireless/hostap/hostap_main.c @@ -741,9 +741,8 @@ void hostap_set_multicast_list_queue(struct work_struct *work) local_info_t *local = container_of(work, local_info_t, set_multicast_list_queue); struct net_device *dev = local->dev; - struct hostap_interface *iface; - iface = netdev_priv(dev); + netdev_priv(dev); if (hostap_set_word(dev, HFA384X_RID_PROMISCUOUSMODE, local->is_promisc)) { printk(KERN_INFO "%s: %sabling promiscuous mode failed\n",
This is a resend from version one due to trying a different approach than the original(probably important to leave netdev_priv() in). In any case have a look, if there's another approach let me know and ill test it out. The below patch fixes a warning im seeing when compiling with gcc 4.6.0 CC [M] drivers/net/wireless/hostap/hostap_main.o drivers/net/wireless/hostap/hostap_main.c: In function 'hostap_set_multicast_list_queue': drivers/net/wireless/hostap/hostap_main.c:744:27: warning: variable 'iface' set but not used Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> --- drivers/net/wireless/hostap/hostap_main.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)