diff mbox

[U-Boot,06/18] dm: lcd: Avoid using the lcd.h header file with driver model

Message ID 1452011474-15207-7-git-send-email-sjg@chromium.org
State Accepted
Commit 6cbf5de7082fdee0bdbc3dd5fe7ac4c84cbf9f7d
Delegated to: Anatolij Gustschin
Headers show

Commit Message

Simon Glass Jan. 5, 2016, 4:31 p.m. UTC 
The LCD functions and definitions are not used with the driver model video
uclass. When all boards are converted over we can remove the file. For now,
use #ifdef to omit the contents.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 common/Makefile |  2 ++
 include/lcd.h   | 12 ++++++++----
 2 files changed, 10 insertions(+), 4 deletions(-)

Comments

Anatolij Gustschin Jan. 17, 2016, 6:40 p.m. UTC | #1 
On Tue,  5 Jan 2016 09:31:02 -0700
Simon Glass <sjg@chromium.org> wrote:

> The LCD functions and definitions are not used with the driver model video
> uclass. When all boards are converted over we can remove the file. For now,
> use #ifdef to omit the contents.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> 
>  common/Makefile |  2 ++
>  include/lcd.h   | 12 ++++++++----
>  2 files changed, 10 insertions(+), 4 deletions(-)

Acked-by: Anatolij Gustschin <agust@denx.de>

--
Anatolij
diff mbox

Patch

diff --git a/common/Makefile b/common/Makefile
index 2a1d9f8..2492275 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -205,7 +205,9 @@  obj-$(CONFIG_I2C_EDID) += edid.o
 obj-$(CONFIG_KALLSYMS) += kallsyms.o
 obj-y += splash.o
 obj-$(CONFIG_SPLASH_SOURCE) += splash_source.o
+ifndef CONFIG_DM_VIDEO
 obj-$(CONFIG_LCD) += lcd.o lcd_console.o
+endif
 obj-$(CONFIG_LCD_ROTATION) += lcd_console_rotation.o
 obj-$(CONFIG_LCD_DT_SIMPLEFB) += lcd_simplefb.o
 obj-$(CONFIG_LYNXKDI) += lynxkdi.o
diff --git a/include/lcd.h b/include/lcd.h
index 59202b7..d7651a8 100644
--- a/include/lcd.h
+++ b/include/lcd.h
@@ -18,6 +18,12 @@ 
 #include <asm/byteorder.h>
 #endif
 
+int bmp_display(ulong addr, int x, int y);
+struct bmp_image *gunzip_bmp(unsigned long addr, unsigned long *lenp,
+			     void **alloc_addr);
+
+#ifndef CONFIG_DM_VIDEO
+
 extern char lcd_is_enabled;
 extern int lcd_line_length;
 extern struct vidinfo panel_info;
@@ -26,10 +32,6 @@  void lcd_ctrl_init(void *lcdbase);
 void lcd_enable(void);
 void lcd_setcolreg(ushort regno, ushort red, ushort green, ushort blue);
 
-struct bmp_image *gunzip_bmp(unsigned long addr, unsigned long *lenp,
-			     void **alloc_addr);
-int bmp_display(ulong addr, int x, int y);
-
 /**
  * Set whether we need to flush the dcache when changing the LCD image. This
  * defaults to off.
@@ -209,4 +211,6 @@  void lcd_sync(void);
 #define PAGE_SIZE	4096
 #endif
 
+#endif /* !CONFIG_DM_VIDEO */
+
 #endif	/* _LCD_H_ */