[tpmdd-devel] tpm: remove unneeded include of actbl2.h
diff mbox

Message ID 1451935183-2514-1-git-send-email-jsnitsel@redhat.com
State New
Headers show

Commit Message

Jerry Snitselaar Jan. 4, 2016, 7:19 p.m. UTC
tpm_tis.c already gets actbl2.h via linux/acpi.h -> acpi/acpi.h ->
acpi/actbl.h -> acpi/actbl2.h, so the direct include in tpm_tis.c
is not needed.

Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
---

Jarrko, this is a trivial thing I noticed while doing some work.
Not sure if you guys care, but thought I'd send it in anyways.

 drivers/char/tpm/tpm_tis.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Jerry Snitselaar Jan. 4, 2016, 8:11 p.m. UTC | #1
On Mon Jan 04 16, Jerry Snitselaar wrote:
>tpm_tis.c already gets actbl2.h via linux/acpi.h -> acpi/acpi.h ->
>acpi/actbl.h -> acpi/actbl2.h, so the direct include in tpm_tis.c
>is not needed.
>
>Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
>---
>
>Jarrko, this is a trivial thing I noticed while doing some work.
>Not sure if you guys care, but thought I'd send it in anyways.
>
> drivers/char/tpm/tpm_tis.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
>index 65f7eec..461d486 100644
>--- a/drivers/char/tpm/tpm_tis.c
>+++ b/drivers/char/tpm/tpm_tis.c
>@@ -28,7 +28,6 @@
> #include <linux/wait.h>
> #include <linux/acpi.h>
> #include <linux/freezer.h>
>-#include <acpi/actbl2.h>
> #include "tpm.h"
>
> enum tis_access {
>-- 
>2.6.1
>

Not sure what happened, but it doesn't look like it CC'd Jarkko even
though it shows it in the git send-email output. Adding the other
maintainers as well.

	0001-tpm-remove-unneeded-include-of-actbl2.h.patch

	From: Jerry Snitselaar <jsnitsel@redhat.com>
	To: tpmdd-devel@lists.sourceforge.net
	Cc: linux-kernel@vger.kernel.org,
		jarkko.sakkinen@linux.intel.com
	Subject: [PATCH] tpm: remove unneeded include of actbl2.h
	Date: Mon,  4 Jan 2016 12:19:43 -0700
	Message-Id: <1451935183-2514-1-git-send-email-jsnitsel@redhat.com>
	X-Mailer: git-send-email 2.6.1

	Send this email? ([y]es|[n]o|[q]uit|[a]ll): a
	OK. Log says:
	Server: smtp.corp.redhat.com
	MAIL FROM:<jsnitsel@redhat.com>
	RCPT TO:<tpmdd-devel@lists.sourceforge.net>
	RCPT TO:<linux-kernel@vger.kernel.org>
	RCPT TO:<jarkko.sakkinen@linux.intel.com>
	From: Jerry Snitselaar <jsnitsel@redhat.com>
	To: tpmdd-devel@lists.sourceforge.net
	Cc: linux-kernel@vger.kernel.org,
		jarkko.sakkinen@linux.intel.com
	Subject: [PATCH] tpm: remove unneeded include of actbl2.h
	Date: Mon,  4 Jan 2016 12:19:43 -0700
	Message-Id: <1451935183-2514-1-git-send-email-jsnitsel@redhat.com>
	X-Mailer: git-send-email 2.6.1

	Result: 250 2.0.0 u04JJkA6027832 Message accepted for delivery


------------------------------------------------------------------------------
Jarkko Sakkinen Jan. 5, 2016, 6:49 a.m. UTC | #2
On Mon, Jan 04, 2016 at 12:19:43PM -0700, Jerry Snitselaar wrote:
> tpm_tis.c already gets actbl2.h via linux/acpi.h -> acpi/acpi.h ->
> acpi/actbl.h -> acpi/actbl2.h, so the direct include in tpm_tis.c
> is not needed.
> 
> Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>

Acked-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko

> ---
> 
> Jarrko, this is a trivial thing I noticed while doing some work.
> Not sure if you guys care, but thought I'd send it in anyways.
> 
>  drivers/char/tpm/tpm_tis.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index 65f7eec..461d486 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -28,7 +28,6 @@
>  #include <linux/wait.h>
>  #include <linux/acpi.h>
>  #include <linux/freezer.h>
> -#include <acpi/actbl2.h>
>  #include "tpm.h"
>  
>  enum tis_access {
> -- 
> 2.6.1
> 

------------------------------------------------------------------------------
Jarkko Sakkinen Jan. 6, 2016, 2:38 p.m. UTC | #3
On Tue, Jan 05, 2016 at 08:49:33AM +0200, Jarkko Sakkinen wrote:
> On Mon, Jan 04, 2016 at 12:19:43PM -0700, Jerry Snitselaar wrote:
> > tpm_tis.c already gets actbl2.h via linux/acpi.h -> acpi/acpi.h ->
> > acpi/actbl.h -> acpi/actbl2.h, so the direct include in tpm_tis.c
> > is not needed.
> > 
> > Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
> 
> Acked-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

Applied to https://github.com/jsakkine/linux-tpmdd/commits/master

/Jarkko

------------------------------------------------------------------------------

Patch
diff mbox

diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index 65f7eec..461d486 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -28,7 +28,6 @@ 
 #include <linux/wait.h>
 #include <linux/acpi.h>
 #include <linux/freezer.h>
-#include <acpi/actbl2.h>
 #include "tpm.h"
 
 enum tis_access {