Patchwork Remove Flag syntax only in c-decl.c write_globals

login
register
mail settings
Submitter Philip Herron
Date June 19, 2010, 1:58 a.m.
Message ID <AANLkTikOgINqcHuF-eh7gYEcn3UKzJFKLqLqDrLQ0oPf@mail.gmail.com>
Download mbox | patch
Permalink /patch/56234/
State New
Headers show

Comments

Philip Herron - June 19, 2010, 1:58 a.m.
Hey

Just a simple trivial patch in c-decl.c in c_write_global_declarations
since toplev.c now checks for this just before calling the langhook
write_globals(). So it should be un-necessary to check for it again.

--Phil
Joseph S. Myers - June 19, 2010, 10:43 a.m.
On Sat, 19 Jun 2010, Philip Herron wrote:

> Hey
> 
> Just a simple trivial patch in c-decl.c in c_write_global_declarations
> since toplev.c now checks for this just before calling the langhook
> write_globals(). So it should be un-necessary to check for it again.

I have committed this patch with the ChangeLog entry:

2010-06-19  Philip Herron  <herron.philip@googlemail.com>

        * c-decl.c (c_write_global_declarations): Don't check
        flag_syntax_only.

For future reference, please include GNU-style ChangeLog entries in patch 
submissions (as plain text for each affected ChangeLog file, not as 
patches to the ChangeLog files) and state the platform on which you tested 
your patch with no regressions.

Patch

From df34437bbe399c2bf6739154f3feaa7adc9a3ee1 Mon Sep 17 00:00:00 2001
From: redbrain <redbrain@crules.org>
Date: Sat, 19 Jun 2010 02:50:08 +0100
Subject: [PATCH] flag_syntax_only check un-needed as toplev.c checks this just before calling langhooks.write_globals()

---
 gcc/c-decl.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/gcc/c-decl.c b/gcc/c-decl.c
index 740ca35..2033a3b 100644
--- a/gcc/c-decl.c
+++ b/gcc/c-decl.c
@@ -9658,11 +9658,6 @@  c_write_global_declarations (void)
   if (pch_file)
     return;
 
-  /* Don't waste time on further processing if -fsyntax-only.
-     Continue for warning and errors issued during lowering though.  */
-  if (flag_syntax_only)
-    return;
-
   /* Close the external scope.  */
   ext_block = pop_scope ();
   external_scope = 0;
-- 
1.7.0.4