[1/1] disable reboot by ctrl-alt-del

From: lf <micro1183@gmail.com>

Most embedded systems do not have a keyboard.
If a keyboard is attached afterwards (e.g. to an accessible USB host port) 
this allows the user to reboot the system by pressing Ctrl-Alt-Del, which
might not be desired.
 
Signed-off-by: lothar felten <felten@vaxnet.de>
---
 package/busybox/inittab  | 2 +-
 package/sysvinit/inittab | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Lothar, All,

On 2016-01-03 23:00 +0100, lothar felten spake thusly:
> From: lf <micro1183@gmail.com>

Be sure to configure your git with your real name, so authorship matches
your SoB line, below.

> Most embedded systems do not have a keyboard.
> If a keyboard is attached afterwards (e.g. to an accessible USB host port) 
> this allows the user to reboot the system by pressing Ctrl-Alt-Del, which
> might not be desired.
>  
> Signed-off-by: lothar felten <felten@vaxnet.de>

Except for the authorship that should be a real, full name:

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Thanks!

Regards,
Yann E. MORIN.

> ---
>  package/busybox/inittab  | 2 +-
>  package/sysvinit/inittab | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/busybox/inittab b/package/busybox/inittab
> index 24d9199..3f49f6b 100644
> --- a/package/busybox/inittab
> +++ b/package/busybox/inittab
> @@ -27,7 +27,7 @@
>  #ttyS0::respawn:/sbin/getty -L ttyS0 115200 vt100 # GENERIC_SERIAL
>  
>  # Stuff to do for the 3-finger salute
> -::ctrlaltdel:/sbin/reboot
> +#::ctrlaltdel:/sbin/reboot
>  
>  # Stuff to do before rebooting
>  ::shutdown:/etc/init.d/rcK
> diff --git a/package/sysvinit/inittab b/package/sysvinit/inittab
> index fc0c9b5..27eb4a6 100644
> --- a/package/sysvinit/inittab
> +++ b/package/sysvinit/inittab
> @@ -15,7 +15,7 @@ si6::sysinit:/etc/init.d/rcS
>  # S0:1:respawn:/sbin/getty -L ttyS0 115200 vt100 # GENERIC_SERIAL
>  
>  # Stuff to do for the 3-finger salute
> -ca::ctrlaltdel:/sbin/reboot
> +#ca::ctrlaltdel:/sbin/reboot
>  
>  # Stuff to do before rebooting
>  shd0:06:wait:/etc/init.d/rcK
> -- 
> 1.9.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

>>>>> "lothar" == lothar felten <felten@vaxnet.de> writes:

 > From: lf <micro1183@gmail.com>
 
 > Most embedded systems do not have a keyboard.
 > If a keyboard is attached afterwards (e.g. to an accessible USB host port) 
 > this allows the user to reboot the system by pressing Ctrl-Alt-Del, which
 > might not be desired.
 
 > Signed-off-by: lothar felten <felten@vaxnet.de>

Committed with the authorship fixed, thanks.

Hello,

On Sun,  3 Jan 2016 23:00:33 +0100, lothar felten wrote:
> From: lf <micro1183@gmail.com>
> 
> Most embedded systems do not have a keyboard.
> If a keyboard is attached afterwards (e.g. to an accessible USB host port) 
> this allows the user to reboot the system by pressing Ctrl-Alt-Del, which
> might not be desired.
>  
> Signed-off-by: lothar felten <felten@vaxnet.de>

Thanks Lothar for your contribution. Your patch has already been
committed, so I hadn't had the time to give my opinion.

My opinion is quite different than the one from Yann and Peter however:
I believe your customization of the ctrl-alt-del behavior is really a
detail, which can very easily be overridden in a post-build script and
therefore does not deserve an additional Config.in option. If we start
adding Config.in options for every possible customization of the
inittab, we will have gazillions of options to solve very specific use
cases.

Best regards,

Thomas

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Hello,
 > On Sun,  3 Jan 2016 23:00:33 +0100, lothar felten wrote:
 >> From: lf <micro1183@gmail.com>
 >> 
 >> Most embedded systems do not have a keyboard.
 >> If a keyboard is attached afterwards (e.g. to an accessible USB host port) 
 >> this allows the user to reboot the system by pressing Ctrl-Alt-Del, which
 >> might not be desired.
 >> 
 >> Signed-off-by: lothar felten <felten@vaxnet.de>

 > Thanks Lothar for your contribution. Your patch has already been
 > committed, so I hadn't had the time to give my opinion.

 > My opinion is quite different than the one from Yann and Peter however:
 > I believe your customization of the ctrl-alt-del behavior is really a
 > detail, which can very easily be overridden in a post-build script and
 > therefore does not deserve an additional Config.in option. If we start
 > adding Config.in options for every possible customization of the
 > inittab, we will have gazillions of options to solve very specific use
 > cases.

Ehh, I think we all agree. This commit didn't add a configuration
option, it simply changed our default behavior to NOT do anything when
ctrl-alt-del is pressed (which is imho a better default).

Hello,

On Mon, 04 Jan 2016 16:18:43 +0100, Peter Korsgaard wrote:

> Ehh, I think we all agree. This commit didn't add a configuration
> option, it simply changed our default behavior to NOT do anything when
> ctrl-alt-del is pressed (which is imho a better default).

Ah, my bad. I had in mind the previous patch from Lothar, i.e "added
option to enable or disable reboot on ctrl-alt-del". Indeed his new
patch, which you committed, does not add a new option, which is
perfectly fine.

Sorry for the noise. That's what happens when you don't read e-mails in
the right order.

Best regards,

Thomas