| Message ID | 1451850998-28639-1-git-send-email-toralf.foerster@gmx.de |
|---|---|
| State | New, archived |
| Headers | show |
On Sun 03-01-16 20:56:37, Toralf Förster wrote: > use the definition in include/uapi/linux/xattr.h > > Signed-off-by: Toralf Förster <toralf.foerster@gmx.de> Looks good. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/ext4/xattr_security.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/xattr_security.c b/fs/ext4/xattr_security.c > index 36f4c1a..1a3d629 100644 > --- a/fs/ext4/xattr_security.c > +++ b/fs/ext4/xattr_security.c > @@ -16,7 +16,7 @@ ext4_xattr_security_list(const struct xattr_handler *handler, > struct dentry *dentry, char *list, size_t list_size, > const char *name, size_t name_len) > { > - const size_t prefix_len = sizeof(XATTR_SECURITY_PREFIX)-1; > + const size_t prefix_len = XATTR_SECURITY_PREFIX_LEN; > const size_t total_len = prefix_len + name_len + 1; > > > -- > 2.4.10 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
I prefer the use of sizeof that can't be faked even by error but why not Le dimanche 03 janvier 2016 à 20:56 +0100, Toralf Förster a écrit : > use the definition in include/uapi/linux/xattr.h > > Signed-off-by: Toralf Förster <toralf.foerster@gmx.de> > --- > fs/ext4/xattr_security.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/xattr_security.c b/fs/ext4/xattr_security.c > index 36f4c1a..1a3d629 100644 > --- a/fs/ext4/xattr_security.c > +++ b/fs/ext4/xattr_security.c > @@ -16,7 +16,7 @@ ext4_xattr_security_list(const struct xattr_handler *handler, > struct dentry *dentry, char *list, size_t list_size, > const char *name, size_t name_len) > { > - const size_t prefix_len = sizeof(XATTR_SECURITY_PREFIX)-1; > + const size_t prefix_len = XATTR_SECURITY_PREFIX_LEN; > const size_t total_len = prefix_len + name_len + 1; > > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/ext4/xattr_security.c b/fs/ext4/xattr_security.c index 36f4c1a..1a3d629 100644 --- a/fs/ext4/xattr_security.c +++ b/fs/ext4/xattr_security.c @@ -16,7 +16,7 @@ ext4_xattr_security_list(const struct xattr_handler *handler, struct dentry *dentry, char *list, size_t list_size, const char *name, size_t name_len) { - const size_t prefix_len = sizeof(XATTR_SECURITY_PREFIX)-1; + const size_t prefix_len = XATTR_SECURITY_PREFIX_LEN; const size_t total_len = prefix_len + name_len + 1;
use the definition in include/uapi/linux/xattr.h Signed-off-by: Toralf Förster <toralf.foerster@gmx.de> --- fs/ext4/xattr_security.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)