diff mbox

package/tremor: select libogg package

Message ID 1451745735-5358-1-git-send-email-romain.naour@gmail.com
State Accepted
Commit 2565b56a11213f14239f7dc7b212855b9987d648
Headers show

Commit Message

Romain Naour Jan. 2, 2016, 2:42 p.m. UTC
tremor depends on libogg package but doesn't select it
in Config.in. so libogg build is trigged at Makefile level.

Since 28f67899e54f15c6e48484ea2976c3e431756bcb, the build
stop if a package build is trigged at Makefile level without
being selected at Config.in level.

Fixes:
http://autobuild.buildroot.net/results/0da/0da3265f0f1e499f5d34ed32b0d13a2eda53f976

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 package/tremor/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni Jan. 2, 2016, 10:26 p.m. UTC | #1
Hello,

On Sat,  2 Jan 2016 15:42:15 +0100, Romain Naour wrote:
> tremor depends on libogg package but doesn't select it
> in Config.in. so libogg build is trigged at Makefile level.
> 
> Since 28f67899e54f15c6e48484ea2976c3e431756bcb, the build
> stop if a package build is trigged at Makefile level without
> being selected at Config.in level.
> 
> Fixes:
> http://autobuild.buildroot.net/results/0da/0da3265f0f1e499f5d34ed32b0d13a2eda53f976
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
>  package/tremor/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Thomas
Peter Korsgaard Jan. 3, 2016, 8:51 p.m. UTC | #2
>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:

 > tremor depends on libogg package but doesn't select it
 > in Config.in. so libogg build is trigged at Makefile level.

 > Since 28f67899e54f15c6e48484ea2976c3e431756bcb, the build
 > stop if a package build is trigged at Makefile level without
 > being selected at Config.in level.

 > Fixes:
 > http://autobuild.buildroot.net/results/0da/0da3265f0f1e499f5d34ed32b0d13a2eda53f976

 > Signed-off-by: Romain Naour <romain.naour@gmail.com>

Committed, thanks.
diff mbox

Patch

diff --git a/package/tremor/Config.in b/package/tremor/Config.in
index 6125926..1a478c4 100644
--- a/package/tremor/Config.in
+++ b/package/tremor/Config.in
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_TREMOR
 	bool "tremor (fixed point vorbis decoder)"
+	select BR2_PACKAGE_LIBOGG
 	help
 	  Tremor is a fixed point implementation of an Ogg Vorbis
 	  decoder. It provides a decoding API similar to libvorbis,