From patchwork Fri Jun 18 15:03:28 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Wolf X-Patchwork-Id: 56199 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B7152B7D86 for ; Sat, 19 Jun 2010 01:12:40 +1000 (EST) Received: from localhost ([127.0.0.1]:57698 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OPdFD-0005aN-Nb for incoming@patchwork.ozlabs.org; Fri, 18 Jun 2010 11:12:35 -0400 Received: from [140.186.70.92] (port=52920 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OPd6n-000808-Cg for qemu-devel@nongnu.org; Fri, 18 Jun 2010 11:03:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OPd6l-0007NS-WD for qemu-devel@nongnu.org; Fri, 18 Jun 2010 11:03:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43437) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OPd6l-0007NO-P2 for qemu-devel@nongnu.org; Fri, 18 Jun 2010 11:03:51 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5IF3pYu019742 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 18 Jun 2010 11:03:51 -0400 Received: from localhost.localdomain (vpn1-6-103.ams2.redhat.com [10.36.6.103]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5IF3dsZ028608; Fri, 18 Jun 2010 11:03:49 -0400 From: Kevin Wolf To: qemu-devel@nongnu.org Date: Fri, 18 Jun 2010 17:03:28 +0200 Message-Id: <1276873409-8235-6-git-send-email-kwolf@redhat.com> In-Reply-To: <1276873409-8235-1-git-send-email-kwolf@redhat.com> References: <1276873409-8235-1-git-send-email-kwolf@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: kwolf@redhat.com Subject: [Qemu-devel] [PATCH 5/6] vmdk: Use bdrv_(p)write_sync for metadata writes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Use bdrv_(p)write_sync to ensure metadata integrity in case of a crash. Signed-off-by: Kevin Wolf --- block/vmdk.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index e659908..2d4ba42 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -150,7 +150,7 @@ static int vmdk_write_cid(BlockDriverState *bs, uint32_t cid) pstrcat(desc, sizeof(desc), tmp_desc); } - if (bdrv_pwrite(bs->file, 0x200, desc, DESC_SIZE) != DESC_SIZE) + if (bdrv_pwrite_sync(bs->file, 0x200, desc, DESC_SIZE) < 0) return -1; return 0; } @@ -471,14 +471,14 @@ static int vmdk_L2update(BlockDriverState *bs, VmdkMetaData *m_data) BDRVVmdkState *s = bs->opaque; /* update L2 table */ - if (bdrv_pwrite(bs->file, ((int64_t)m_data->l2_offset * 512) + (m_data->l2_index * sizeof(m_data->offset)), - &(m_data->offset), sizeof(m_data->offset)) != sizeof(m_data->offset)) + if (bdrv_pwrite_sync(bs->file, ((int64_t)m_data->l2_offset * 512) + (m_data->l2_index * sizeof(m_data->offset)), + &(m_data->offset), sizeof(m_data->offset)) < 0) return -1; /* update backup L2 table */ if (s->l1_backup_table_offset != 0) { m_data->l2_offset = s->l1_backup_table[m_data->l1_index]; - if (bdrv_pwrite(bs->file, ((int64_t)m_data->l2_offset * 512) + (m_data->l2_index * sizeof(m_data->offset)), - &(m_data->offset), sizeof(m_data->offset)) != sizeof(m_data->offset)) + if (bdrv_pwrite_sync(bs->file, ((int64_t)m_data->l2_offset * 512) + (m_data->l2_index * sizeof(m_data->offset)), + &(m_data->offset), sizeof(m_data->offset)) < 0) return -1; }