| Message ID | 1451218972-22156-2-git-send-email-pbrobinson@gmail.com |
|---|---|
| State | New |
| Headers | show |
On Sun, Dec 27, 2015 at 12:22:51PM +0000, Peter Robinson wrote: > If you select CONFIG_PINCTR for another unrelated architecture > you need to set all the Intel pinctrl options even though they're not > required. Mask them if not required. > > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> > --- > drivers/pinctrl/intel/Kconfig | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pinctrl/intel/Kconfig b/drivers/pinctrl/intel/Kconfig > index 4d2efad..68fa13a 100644 > --- a/drivers/pinctrl/intel/Kconfig > +++ b/drivers/pinctrl/intel/Kconfig > @@ -2,6 +2,8 @@ > # Intel pin control drivers > # > > +if X86_GENERIC || COMPILE_TEST > + > config PINCTRL_BAYTRAIL > bool "Intel Baytrail GPIO pin control" > depends on GPIOLIB && ACPI All of them already depend on CONFIG_ACPI so if your unrelated architecture does not provide that then you should not see any of these. > @@ -50,3 +52,5 @@ config PINCTRL_SUNRISEPOINT > Sunrisepoint is the PCH of Intel Skylake. This pinctrl driver > provides an interface that allows configuring of PCH pins and > using them as GPIOs. > + > +endif > -- > 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Dec 28, 2015 at 12:00 PM, Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > On Sun, Dec 27, 2015 at 12:22:51PM +0000, Peter Robinson wrote: >> If you select CONFIG_PINCTR for another unrelated architecture >> you need to set all the Intel pinctrl options even though they're not >> required. Mask them if not required. >> >> Signed-off-by: Peter Robinson <pbrobinson@gmail.com> >> --- >> drivers/pinctrl/intel/Kconfig | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/pinctrl/intel/Kconfig b/drivers/pinctrl/intel/Kconfig >> index 4d2efad..68fa13a 100644 >> --- a/drivers/pinctrl/intel/Kconfig >> +++ b/drivers/pinctrl/intel/Kconfig >> @@ -2,6 +2,8 @@ >> # Intel pin control drivers >> # >> >> +if X86_GENERIC || COMPILE_TEST >> + >> config PINCTRL_BAYTRAIL >> bool "Intel Baytrail GPIO pin control" >> depends on GPIOLIB && ACPI > > All of them already depend on CONFIG_ACPI so if your unrelated > architecture does not provide that then you should not see any of these. ACPI is available on arm64 and there's patches around for ARM, none of which would support the intel hardware, hence the patch. Peter -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Dec 28, 2015 at 12:13:32PM +0000, Peter Robinson wrote: > On Mon, Dec 28, 2015 at 12:00 PM, Mika Westerberg > <mika.westerberg@linux.intel.com> wrote: > > On Sun, Dec 27, 2015 at 12:22:51PM +0000, Peter Robinson wrote: > >> If you select CONFIG_PINCTR for another unrelated architecture > >> you need to set all the Intel pinctrl options even though they're not > >> required. Mask them if not required. > >> > >> Signed-off-by: Peter Robinson <pbrobinson@gmail.com> > >> --- > >> drivers/pinctrl/intel/Kconfig | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/drivers/pinctrl/intel/Kconfig b/drivers/pinctrl/intel/Kconfig > >> index 4d2efad..68fa13a 100644 > >> --- a/drivers/pinctrl/intel/Kconfig > >> +++ b/drivers/pinctrl/intel/Kconfig > >> @@ -2,6 +2,8 @@ > >> # Intel pin control drivers > >> # > >> > >> +if X86_GENERIC || COMPILE_TEST > >> + > >> config PINCTRL_BAYTRAIL > >> bool "Intel Baytrail GPIO pin control" > >> depends on GPIOLIB && ACPI > > > > All of them already depend on CONFIG_ACPI so if your unrelated > > architecture does not provide that then you should not see any of these. > > ACPI is available on arm64 and there's patches around for ARM, none of > which would support the intel hardware, hence the patch. I see. Then I suggest you use "if X86 || COMPILE_TEST" instead of X86_GENERIC because the latter does not even cover 64-bit CPUs (and is more about optimizing for generic 32-bit CPUs than selecting proper CPU architecture). -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/intel/Kconfig b/drivers/pinctrl/intel/Kconfig index 4d2efad..68fa13a 100644 --- a/drivers/pinctrl/intel/Kconfig +++ b/drivers/pinctrl/intel/Kconfig @@ -2,6 +2,8 @@ # Intel pin control drivers # +if X86_GENERIC || COMPILE_TEST + config PINCTRL_BAYTRAIL bool "Intel Baytrail GPIO pin control" depends on GPIOLIB && ACPI @@ -50,3 +52,5 @@ config PINCTRL_SUNRISEPOINT Sunrisepoint is the PCH of Intel Skylake. This pinctrl driver provides an interface that allows configuring of PCH pins and using them as GPIOs. + +endif
If you select CONFIG_PINCTR for another unrelated architecture you need to set all the Intel pinctrl options even though they're not required. Mask them if not required. Signed-off-by: Peter Robinson <pbrobinson@gmail.com> --- drivers/pinctrl/intel/Kconfig | 4 ++++ 1 file changed, 4 insertions(+)