diff mbox

Osmo-PCU: make error

Message ID 1314663197.15142938.1451129230317.JavaMail.zimbra@kvk.uni-obuda.hu
State Superseded
Headers show

Commit Message

Sipos Csaba Dec. 26, 2015, 11:27 a.m. UTC 
Hi Harald,

It all compiles fine now. Thx for the fix :-)

Regards,
Csaba

----- Eredeti üzenet -----
Feladó: "Sipos Csaba" <sipos.csaba@kvk.uni-obuda.hu>
Címzett: "Harald Welte" <laforge@gnumonks.org>
Másolatot kap: "OpenBSC Mailing List" <openbsc@lists.osmocom.org>
Elküldött üzenetek: Péntek, 2015. December 25. 17:17:28
Tárgy: Re: Osmo-PCU: make error

Thx Harald, will test it and report back.

Regards,
Csaba

----- Eredeti üzenet -----
Feladó: "Harald Welte" <laforge@gnumonks.org>
Címzett: "Sipos Csaba" <sipos.csaba@kvk.uni-obuda.hu>
Másolatot kap: "Jacob Erlbeck" <jerlbeck@sysmocom.de>, "OpenBSC Mailing List" <openbsc@lists.osmocom.org>
Elküldött üzenetek: Péntek, 2015. December 25. 17:15:51
Tárgy: Re: Osmo-PCU: make error

Hi Sipos,

On Fri, Dec 25, 2015 at 03:50:45PM +0100, Sipos Csaba wrote:
> /usr/local/include/osmocom/core/prim.h:23:27: error: uninitialized const 'osmo_prim_op_names' [-fpermissive]
>  const struct value_string osmo_prim_op_names[5];

This was introduced by one of my recent libosmocore changes, sorry.

The patch below (just pushed to libosmocore master) should fix it.

>From c959afdcd9d8f227f4a72a915ac2e3f79d1d1d3b Mon Sep 17 00:00:00 2001
From: Harald Welte <laforge@gnumonks.org>
Date: Fri, 25 Dec 2015 17:14:07 +0100
Subject: [PATCH] osmo_prim_op_names should be extern

---
 include/osmocom/core/prim.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/include/osmocom/core/prim.h b/include/osmocom/core/prim.h
index e920eb8..9e71007 100644
--- a/include/osmocom/core/prim.h
+++ b/include/osmocom/core/prim.h
@@ -20,7 +20,7 @@  enum osmo_prim_operation {
 	PRIM_OP_CONFIRM,	/*!< \brief cofirm */
 };
 
-const struct value_string osmo_prim_op_names[5];
+extern const struct value_string osmo_prim_op_names[5];
 
 #define _SAP_GSM_SHIFT	24