diff mbox

[v2,2/2] Fixing xdriver_xf86-video-ati dependencies

Message ID 1450874992-15627-3-git-send-email-ltrimas@synopsys.com
State Superseded
Headers show

Commit Message

Lada Trimasova Dec. 23, 2015, 12:49 p.m. UTC
This package depends on the radeon driver from libdrm and depends on
DRI support in xserver_xorg-server, to achieve this we select the
Radeon mesa3d DRI driver.

Fixes:
http://autobuild.buildroot.net/results/9da/9da4ffdf1c4ec78ae37322e253cb769340116035

Signed-off-by: Lada Trimasova <ltrimas@synopsys.com>
Cc: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Peter Korsgaard <peter@korsgaard.com>
---
 package/x11r7/xdriver_xf86-video-ati/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Yann E. MORIN Dec. 23, 2015, 6:31 p.m. UTC | #1
Lada, All,

On 2015-12-23 15:49 +0300, Lada Trimasova spake thusly:
> This package depends on the radeon driver from libdrm and depends on
> DRI support in xserver_xorg-server, to achieve this we select the
> Radeon mesa3d DRI driver.
> 
> Fixes:
> http://autobuild.buildroot.net/results/9da/9da4ffdf1c4ec78ae37322e253cb769340116035
> 
> Signed-off-by: Lada Trimasova <ltrimas@synopsys.com>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Peter Korsgaard <peter@korsgaard.com>
> ---
>  package/x11r7/xdriver_xf86-video-ati/Config.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/x11r7/xdriver_xf86-video-ati/Config.in b/package/x11r7/xdriver_xf86-video-ati/Config.in
> index 191c20f..00d91bd 100644
> --- a/package/x11r7/xdriver_xf86-video-ati/Config.in
> +++ b/package/x11r7/xdriver_xf86-video-ati/Config.in
> @@ -1,8 +1,9 @@
>  config BR2_PACKAGE_XDRIVER_XF86_VIDEO_ATI
>  	bool "xf86-video-ati"
>  	depends on BR2_PACKAGE_MESA3D
> -	select BR2_PACKAGE_LIBDRM        if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
> -	select BR2_PACKAGE_LIBDRM_RADEON if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
> +	select BR2_PACKAGE_LIBDRM
> +	select BR2_PACKAGE_LIBDRM_RADEON
> +	select BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON

Sorry that I missed it in my previous reply, but you select libdrm, so
you need to propagate its dependencies, too:

    depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm -> libpthread-stubs

This dependency is currently not a problem, because mesa3d hasa stricter
dependency on NPTL, but you still have to propagate the dependencies of
the packages you select.

Regards,
Yann E. MORIN.

>  	select BR2_PACKAGE_XLIB_LIBXCOMPOSITE
>  	select BR2_PACKAGE_XPROTO_FONTSPROTO
>  	select BR2_PACKAGE_XPROTO_GLPROTO
> -- 
> 2.5.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox

Patch

diff --git a/package/x11r7/xdriver_xf86-video-ati/Config.in b/package/x11r7/xdriver_xf86-video-ati/Config.in
index 191c20f..00d91bd 100644
--- a/package/x11r7/xdriver_xf86-video-ati/Config.in
+++ b/package/x11r7/xdriver_xf86-video-ati/Config.in
@@ -1,8 +1,9 @@ 
 config BR2_PACKAGE_XDRIVER_XF86_VIDEO_ATI
 	bool "xf86-video-ati"
 	depends on BR2_PACKAGE_MESA3D
-	select BR2_PACKAGE_LIBDRM        if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
-	select BR2_PACKAGE_LIBDRM_RADEON if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
+	select BR2_PACKAGE_LIBDRM
+	select BR2_PACKAGE_LIBDRM_RADEON
+	select BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
 	select BR2_PACKAGE_XLIB_LIBXCOMPOSITE
 	select BR2_PACKAGE_XPROTO_FONTSPROTO
 	select BR2_PACKAGE_XPROTO_GLPROTO