diff mbox

[2/3] acpi: pcc: fwts_mmap failure is FWTS_MAP_FAILED and not NULL

Message ID 1450834972-22066-3-git-send-email-colin.king@canonical.com
State Accepted
Headers show

Commit Message

Colin Ian King Dec. 23, 2015, 1:42 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Should be checking for FWTS_MAP_FAILED on a failed fwts_mmap and not
a NULL

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpi/pcc/pcc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alex Hung Dec. 23, 2015, 3:40 a.m. UTC | #1 
On 2015-12-23 09:42 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Should be checking for FWTS_MAP_FAILED on a failed fwts_mmap and not
> a NULL
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/acpi/pcc/pcc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acpi/pcc/pcc.c b/src/acpi/pcc/pcc.c
> index da66aec..799e773 100644
> --- a/src/acpi/pcc/pcc.c
> +++ b/src/acpi/pcc/pcc.c
> @@ -110,7 +110,7 @@ static void pcc_check_pcc_header(
>   	fwts_pcc_header *hdr;
>
>   	hdr = (fwts_pcc_header *)fwts_mmap((off_t)addr, (size_t)length);
> -	if (hdr == NULL) {
> +	if (hdr == FWTS_MAP_FAILED) {
>   		fwts_log_info(fw, "Failed to memory map PCC header 0x%" PRIx64
>   			"..0x%" PRIx64 ".", addr, addr + length);
>   		return;
>


Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu Jan. 7, 2016, 2:25 a.m. UTC | #2 
On 2015年12月23日 09:42, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Should be checking for FWTS_MAP_FAILED on a failed fwts_mmap and not
> a NULL
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/acpi/pcc/pcc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acpi/pcc/pcc.c b/src/acpi/pcc/pcc.c
> index da66aec..799e773 100644
> --- a/src/acpi/pcc/pcc.c
> +++ b/src/acpi/pcc/pcc.c
> @@ -110,7 +110,7 @@ static void pcc_check_pcc_header(
>   	fwts_pcc_header *hdr;
>
>   	hdr = (fwts_pcc_header *)fwts_mmap((off_t)addr, (size_t)length);
> -	if (hdr == NULL) {
> +	if (hdr == FWTS_MAP_FAILED) {
>   		fwts_log_info(fw, "Failed to memory map PCC header 0x%" PRIx64
>   			"..0x%" PRIx64 ".", addr, addr + length);
>   		return;
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox

Patch

diff --git a/src/acpi/pcc/pcc.c b/src/acpi/pcc/pcc.c
index da66aec..799e773 100644
--- a/src/acpi/pcc/pcc.c
+++ b/src/acpi/pcc/pcc.c
@@ -110,7 +110,7 @@  static void pcc_check_pcc_header(
 	fwts_pcc_header *hdr;
 
 	hdr = (fwts_pcc_header *)fwts_mmap((off_t)addr, (size_t)length);
-	if (hdr == NULL) {
+	if (hdr == FWTS_MAP_FAILED) {
 		fwts_log_info(fw, "Failed to memory map PCC header 0x%" PRIx64
 			"..0x%" PRIx64 ".", addr, addr + length);
 		return;