diff mbox

[1/1] nfs-utils: install /etc/nfsmount.conf

Message ID 1450707537-30154-2-git-send-email-yba@tkos.co.il
State Changes Requested
Headers show

Commit Message

Jonathan Ben Avraham Dec. 21, 2015, 2:18 p.m. UTC 
From: Jonathan Ben Avraham <yba@tkos.co.il>

Installs /etc/nfsmount.conf on the target, mainly to be able to configure the
the NFS version that mount.nfs uses by default.

Signed-off-by: Jonathan Ben Avraham <yba@tkos.co.il>
---
 package/nfs-utils/nfs-utils.mk |    3 +++
 1 file changed, 3 insertions(+)

Comments

Thomas Petazzoni Dec. 21, 2015, 3:16 p.m. UTC | #1 
Dear Jonathan Ben-Avraham,

On Mon, 21 Dec 2015 16:18:56 +0200, Jonathan Ben-Avraham wrote:

> diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
> index 30f12fd..55b75e2 100644
> --- a/package/nfs-utils/nfs-utils.mk
> +++ b/package/nfs-utils/nfs-utils.mk
> @@ -38,6 +38,9 @@ endif
>  define NFS_UTILS_INSTALL_FIXUP
>  	rm -f $(NFS_UTILS_TARGETS_)
>  	touch $(TARGET_DIR)/etc/exports
> +	$(INSTALL) -m 744 \

Why 744 and not 644 ? It doesn't make much sense to have an executable
configuration file.

Also, please use the -D option.

> +		$(BUILD_DIR)/nfs-utils-$(NFS_UTILS_VERSION)/utils/mount/nfsmount.conf \

Please use:

		$(@D)/utils/mount/nfsmount.conf

> +		$(TARGET_DIR)/etc

And a full destination path here:

		$(TARGET_DIR)/etc/nfsmount.conf

Thanks!

Thomas
Jonathan Ben Avraham Dec. 22, 2015, 5:13 p.m. UTC | #2 
On Mon, 21 Dec 2015, Thomas Petazzoni wrote:

> Date: Mon, 21 Dec 2015 16:16:58 +0100
> From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> To: Jonathan Ben-Avraham <yba@tkos.co.il>
> Cc: buildroot@busybox.net
> Subject: Re: [Buildroot] [PATCH 1/1] nfs-utils: install /etc/nfsmount.conf
> 
> Dear Jonathan Ben-Avraham,
>
> On Mon, 21 Dec 2015 16:18:56 +0200, Jonathan Ben-Avraham wrote:
>
>> diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
>> index 30f12fd..55b75e2 100644
>> --- a/package/nfs-utils/nfs-utils.mk
>> +++ b/package/nfs-utils/nfs-utils.mk
>> @@ -38,6 +38,9 @@ endif
>>  define NFS_UTILS_INSTALL_FIXUP
>>  	rm -f $(NFS_UTILS_TARGETS_)
>>  	touch $(TARGET_DIR)/etc/exports
>> +	$(INSTALL) -m 744 \
>
> Why 744 and not 644 ? It doesn't make much sense to have an executable
> configuration file.
>
> Also, please use the -D option.
>
>> +		$(BUILD_DIR)/nfs-utils-$(NFS_UTILS_VERSION)/utils/mount/nfsmount.conf \
>
> Please use:
>
> 		$(@D)/utils/mount/nfsmount.conf
>
>> +		$(TARGET_DIR)/etc
>
> And a full destination path here:
>
> 		$(TARGET_DIR)/etc/nfsmount.conf
>
> Thanks!
>
> Thomas
>

Hi Thomas,
Thanks. I submitted another version, v1, of the patch just now.

  - yba
diff mbox

Patch

diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
index 30f12fd..55b75e2 100644
--- a/package/nfs-utils/nfs-utils.mk
+++ b/package/nfs-utils/nfs-utils.mk
@@ -38,6 +38,9 @@  endif
 define NFS_UTILS_INSTALL_FIXUP
 	rm -f $(NFS_UTILS_TARGETS_)
 	touch $(TARGET_DIR)/etc/exports
+	$(INSTALL) -m 744 \
+		$(BUILD_DIR)/nfs-utils-$(NFS_UTILS_VERSION)/utils/mount/nfsmount.conf \
+		$(TARGET_DIR)/etc
 endef
 NFS_UTILS_POST_INSTALL_TARGET_HOOKS += NFS_UTILS_INSTALL_FIXUP