| Message ID | 1450688648-52033-1-git-send-email-yanmiaobest@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
On Mon, Dec 21, 2015 at 5:04 PM, Miao Yan <yanmiaobest@gmail.com> wrote: > In struct e1000_rx_desc, field 'length' is declared as > uint16_t, so use le16_to_cpu() to do endianess conversion. > > Also drop conversion on 'status' which is declared as > uint8_t. > > Signed-off-by: Miao Yan <yanmiaobest@gmail.com> > --- > drivers/net/e1000.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Hi Miao, On Mon, Dec 21, 2015 at 5:43 PM, Bin Meng <bmeng.cn@gmail.com> wrote: > On Mon, Dec 21, 2015 at 5:04 PM, Miao Yan <yanmiaobest@gmail.com> wrote: >> In struct e1000_rx_desc, field 'length' is declared as >> uint16_t, so use le16_to_cpu() to do endianess conversion. >> >> Also drop conversion on 'status' which is declared as >> uint8_t. >> >> Signed-off-by: Miao Yan <yanmiaobest@gmail.com> >> --- >> drivers/net/e1000.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> BTW: two typos, hepler in the commit title endianess in the commit title and body Regards, Bin
Hi Bin, 2015-12-21 17:53 GMT+08:00 Bin Meng <bmeng.cn@gmail.com>: > Hi Miao, > > On Mon, Dec 21, 2015 at 5:43 PM, Bin Meng <bmeng.cn@gmail.com> wrote: >> On Mon, Dec 21, 2015 at 5:04 PM, Miao Yan <yanmiaobest@gmail.com> wrote: >>> In struct e1000_rx_desc, field 'length' is declared as >>> uint16_t, so use le16_to_cpu() to do endianess conversion. >>> >>> Also drop conversion on 'status' which is declared as >>> uint8_t. >>> >>> Signed-off-by: Miao Yan <yanmiaobest@gmail.com> >>> --- >>> drivers/net/e1000.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >> >> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > > BTW: two typos, > > hepler in the commit title > endianess in the commit title and body Thanks for catching these. Will send v2. > > Regards, > Bin
diff --git a/drivers/net/e1000.c b/drivers/net/e1000.c index 2ba03ed..6124bf0 100644 --- a/drivers/net/e1000.c +++ b/drivers/net/e1000.c @@ -5165,11 +5165,11 @@ _e1000_poll(struct e1000_hw *hw) inval_end = inval_start + roundup(sizeof(*rd), ARCH_DMA_MINALIGN); invalidate_dcache_range(inval_start, inval_end); - if (!(le32_to_cpu(rd->status)) & E1000_RXD_STAT_DD) + if (!(rd->status & E1000_RXD_STAT_DD)) return 0; /* DEBUGOUT("recv: packet len=%d\n", rd->length); */ /* Packet received, make sure the data are re-loaded from RAM. */ - len = le32_to_cpu(rd->length); + len = le16_to_cpu(rd->length); invalidate_dcache_range((unsigned long)packet, (unsigned long)packet + roundup(len, ARCH_DMA_MINALIGN));
In struct e1000_rx_desc, field 'length' is declared as uint16_t, so use le16_to_cpu() to do endianess conversion. Also drop conversion on 'status' which is declared as uint8_t. Signed-off-by: Miao Yan <yanmiaobest@gmail.com> --- drivers/net/e1000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)