| Message ID | 1450502540-8744-6-git-send-email-ross.zwisler@linux.intel.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Fri 18-12-15 22:22:18, Ross Zwisler wrote: > To properly support the new DAX fsync/msync infrastructure filesystems > need to call dax_pfn_mkwrite() so that DAX can track when user pages are > dirtied. The patch looks good to me. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com> > --- > fs/ext2/file.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/ext2/file.c b/fs/ext2/file.c > index 11a42c5..2c88d68 100644 > --- a/fs/ext2/file.c > +++ b/fs/ext2/file.c > @@ -102,8 +102,8 @@ static int ext2_dax_pfn_mkwrite(struct vm_area_struct *vma, > { > struct inode *inode = file_inode(vma->vm_file); > struct ext2_inode_info *ei = EXT2_I(inode); > - int ret = VM_FAULT_NOPAGE; > loff_t size; > + int ret; > > sb_start_pagefault(inode->i_sb); > file_update_time(vma->vm_file); > @@ -113,6 +113,8 @@ static int ext2_dax_pfn_mkwrite(struct vm_area_struct *vma, > size = (i_size_read(inode) + PAGE_SIZE - 1) >> PAGE_SHIFT; > if (vmf->pgoff >= size) > ret = VM_FAULT_SIGBUS; > + else > + ret = dax_pfn_mkwrite(vma, vmf); > > up_read(&ei->dax_sem); > sb_end_pagefault(inode->i_sb); > -- > 2.5.0 > >
diff --git a/fs/ext2/file.c b/fs/ext2/file.c index 11a42c5..2c88d68 100644 --- a/fs/ext2/file.c +++ b/fs/ext2/file.c @@ -102,8 +102,8 @@ static int ext2_dax_pfn_mkwrite(struct vm_area_struct *vma, { struct inode *inode = file_inode(vma->vm_file); struct ext2_inode_info *ei = EXT2_I(inode); - int ret = VM_FAULT_NOPAGE; loff_t size; + int ret; sb_start_pagefault(inode->i_sb); file_update_time(vma->vm_file); @@ -113,6 +113,8 @@ static int ext2_dax_pfn_mkwrite(struct vm_area_struct *vma, size = (i_size_read(inode) + PAGE_SIZE - 1) >> PAGE_SHIFT; if (vmf->pgoff >= size) ret = VM_FAULT_SIGBUS; + else + ret = dax_pfn_mkwrite(vma, vmf); up_read(&ei->dax_sem); sb_end_pagefault(inode->i_sb);
To properly support the new DAX fsync/msync infrastructure filesystems need to call dax_pfn_mkwrite() so that DAX can track when user pages are dirtied. Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com> --- fs/ext2/file.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)