diff mbox

[6/6] uefidump: add dumping global variable SysPrep####

Message ID 1450420314-10472-7-git-send-email-ivan.hu@canonical.com
State Accepted
Headers show

Commit Message

Ivan Hu Dec. 18, 2015, 6:31 a.m. UTC 
sync up with uefi spec 2.5

Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
---
 src/uefi/uefidump/uefidump.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Alex Hung Dec. 22, 2015, 6:41 a.m. UTC | #1 
On 12/18/2015 02:31 PM, Ivan Hu wrote:
> sync up with uefi spec 2.5
>
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>   src/uefi/uefidump/uefidump.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/src/uefi/uefidump/uefidump.c b/src/uefi/uefidump/uefidump.c
> index 6caf501..a3a544e 100644
> --- a/src/uefi/uefidump/uefidump.c
> +++ b/src/uefi/uefidump/uefidump.c
> @@ -1438,6 +1438,16 @@ static void uefidump_var(fwts_framework *fw, fwts_uefi_var *var)
>   		return;
>   	}
>
> +	/*
> +	 * Check the System Prep application load option SysPrep####. #### is a printed hex value.
> +	 */
> +	if ((strlen(varname) == 11) && (strncmp(varname, "SysPrep", 7) == 0)
> +			&& isxdigit(varname[7]) && isxdigit(varname[8])
> +			&& isxdigit(varname[9]) && isxdigit(varname[10])) {
> +		uefidump_info_bootdev(fw, var);
> +		return;
> +	}
> +
>   	/* otherwise just do a plain old hex dump */
>   	uefidump_var_hexdump(fw, var);
>   }
>

Acked-by: Alex Hung <alex.hung@canonical.com>
Colin Ian King Jan. 4, 2016, 11:17 a.m. UTC | #2 
On 18/12/15 06:31, Ivan Hu wrote:
> sync up with uefi spec 2.5
> 
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>  src/uefi/uefidump/uefidump.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/src/uefi/uefidump/uefidump.c b/src/uefi/uefidump/uefidump.c
> index 6caf501..a3a544e 100644
> --- a/src/uefi/uefidump/uefidump.c
> +++ b/src/uefi/uefidump/uefidump.c
> @@ -1438,6 +1438,16 @@ static void uefidump_var(fwts_framework *fw, fwts_uefi_var *var)
>  		return;
>  	}
>  
> +	/*
> +	 * Check the System Prep application load option SysPrep####. #### is a printed hex value.
> +	 */
> +	if ((strlen(varname) == 11) && (strncmp(varname, "SysPrep", 7) == 0)
> +			&& isxdigit(varname[7]) && isxdigit(varname[8])
> +			&& isxdigit(varname[9]) && isxdigit(varname[10])) {
> +		uefidump_info_bootdev(fw, var);
> +		return;
> +	}
> +
>  	/* otherwise just do a plain old hex dump */
>  	uefidump_var_hexdump(fw, var);
>  }
> 
Acked-by: Colin Ian King <colin.king@canonical.com>
diff mbox

Patch

diff --git a/src/uefi/uefidump/uefidump.c b/src/uefi/uefidump/uefidump.c
index 6caf501..a3a544e 100644
--- a/src/uefi/uefidump/uefidump.c
+++ b/src/uefi/uefidump/uefidump.c
@@ -1438,6 +1438,16 @@  static void uefidump_var(fwts_framework *fw, fwts_uefi_var *var)
 		return;
 	}
 
+	/*
+	 * Check the System Prep application load option SysPrep####. #### is a printed hex value.
+	 */
+	if ((strlen(varname) == 11) && (strncmp(varname, "SysPrep", 7) == 0)
+			&& isxdigit(varname[7]) && isxdigit(varname[8])
+			&& isxdigit(varname[9]) && isxdigit(varname[10])) {
+		uefidump_info_bootdev(fw, var);
+		return;
+	}
+
 	/* otherwise just do a plain old hex dump */
 	uefidump_var_hexdump(fw, var);
 }