| Message ID | 1450270635-27080-5-git-send-email-marcin.krzeminski@nokia.com |
|---|---|
| State | New |
| Headers | show |
Your commit message subject line should be a little shorter and lengthier explanations of the patch content go here as a paragraph. You should also have subsystem prefixes to patch subject lines. This patch would be something like: block: m25p80: widen flags variable Extend the width of the flags variable to support the already existing (but unused) WR_1 flag, which is above the range of 8 bits. This is turn allows support of EEPROM emulation which requires the WR_1 feature. On Wed, Dec 16, 2015 at 4:57 AM, <marcin.krzeminski@nokia.com> wrote: > From: Marcin Krzeminski <marcin.krzeminski@nokia.com> > > Signed-off-by: Marcin Krzeminski <marcin.krzeminski@nokia.com> Otherwise: Reviewed-by: Peter Crosthwaite <crosthwaite.peter@gmail.com> Regards, Peter > --- > hw/block/m25p80.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c > index 5e07b57..fbbfd1d 100644 > --- a/hw/block/m25p80.c > +++ b/hw/block/m25p80.c > @@ -60,7 +60,7 @@ typedef struct FlashPartInfo { > uint32_t sector_size; > uint32_t n_sectors; > uint32_t page_size; > - uint8_t flags; > + uint16_t flags; > } FlashPartInfo; > > /* adapted from linux */ > -- > 2.5.0 > >
W dniu 21.12.2015 o 12:23, Peter Crosthwaite pisze: > Your commit message subject line should be a little shorter and > lengthier explanations of the patch content go here as a paragraph. > You should also have subsystem prefixes to patch subject lines. This > patch would be something like: > > block: m25p80: widen flags variable > > Extend the width of the flags variable to support the already existing > (but unused) WR_1 flag, which is above the range of 8 bits. This is > turn allows support of EEPROM emulation which requires the WR_1 > feature. Thanks, Marcin > > On Wed, Dec 16, 2015 at 4:57 AM, <marcin.krzeminski@nokia.com> wrote: >> From: Marcin Krzeminski <marcin.krzeminski@nokia.com> >> >> Signed-off-by: Marcin Krzeminski <marcin.krzeminski@nokia.com> > > Otherwise: > > Reviewed-by: Peter Crosthwaite <crosthwaite.peter@gmail.com> > > Regards, > Peter > >> --- >> hw/block/m25p80.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c >> index 5e07b57..fbbfd1d 100644 >> --- a/hw/block/m25p80.c >> +++ b/hw/block/m25p80.c >> @@ -60,7 +60,7 @@ typedef struct FlashPartInfo { >> uint32_t sector_size; >> uint32_t n_sectors; >> uint32_t page_size; >> - uint8_t flags; >> + uint16_t flags; >> } FlashPartInfo; >> >> /* adapted from linux */ >> -- >> 2.5.0 >> >> > >
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 5e07b57..fbbfd1d 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -60,7 +60,7 @@ typedef struct FlashPartInfo { uint32_t sector_size; uint32_t n_sectors; uint32_t page_size; - uint8_t flags; + uint16_t flags; } FlashPartInfo; /* adapted from linux */