diff mbox

[4/9] lib: fwts_acpi_table: remove redundant store to rsdt

Message ID 1450227105-29374-4-git-send-email-colin.king@canonical.com
State Accepted
Headers show

Commit Message

Colin Ian King Dec. 16, 2015, 12:51 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Static analysis from clang scan-build found a redundant store
to rsdt that can be removed.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/src/fwts_acpi_tables.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Alex Hung Dec. 16, 2015, 3:49 a.m. UTC | #1 
On 2015-12-16 08:51 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Static analysis from clang scan-build found a redundant store
> to rsdt that can be removed.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/lib/src/fwts_acpi_tables.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c
> index 42aefcc..0a1af13 100644
> --- a/src/lib/src/fwts_acpi_tables.c
> +++ b/src/lib/src/fwts_acpi_tables.c
> @@ -994,7 +994,6 @@ static int fwts_acpi_load_tables_fixup(fwts_framework *fw)
>   		return FWTS_ERROR;
>   	}
>   	if (table) {
> -		rsdt = (fwts_acpi_table_rsdt *)table->data;
>   		rsdt_fake_addr = table->addr;
>   	} else {
>   		/* No RSDT? go and fake one */
>

Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu Dec. 16, 2015, 6:44 a.m. UTC | #2 
On 2015年12月16日 08:51, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Static analysis from clang scan-build found a redundant store
> to rsdt that can be removed.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/lib/src/fwts_acpi_tables.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c
> index 42aefcc..0a1af13 100644
> --- a/src/lib/src/fwts_acpi_tables.c
> +++ b/src/lib/src/fwts_acpi_tables.c
> @@ -994,7 +994,6 @@ static int fwts_acpi_load_tables_fixup(fwts_framework *fw)
>   		return FWTS_ERROR;
>   	}
>   	if (table) {
> -		rsdt = (fwts_acpi_table_rsdt *)table->data;
>   		rsdt_fake_addr = table->addr;
>   	} else {
>   		/* No RSDT? go and fake one */
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox

Patch

diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c
index 42aefcc..0a1af13 100644
--- a/src/lib/src/fwts_acpi_tables.c
+++ b/src/lib/src/fwts_acpi_tables.c
@@ -994,7 +994,6 @@  static int fwts_acpi_load_tables_fixup(fwts_framework *fw)
 		return FWTS_ERROR;
 	}
 	if (table) {
-		rsdt = (fwts_acpi_table_rsdt *)table->data;
 		rsdt_fake_addr = table->addr;
 	} else {
 		/* No RSDT? go and fake one */