diff mbox

[1/9] acpi: dbg2: remove dead store to ptr1

Message ID 1450227105-29374-1-git-send-email-colin.king@canonical.com
State Accepted
Headers show

Commit Message

Colin Ian King Dec. 16, 2015, 12:51 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Static analysis from clang scan-build detected a dead store
to ptr1 which we can safely remove.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpi/dbg2/dbg2.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Alex Hung Dec. 16, 2015, 3:48 a.m. UTC | #1 
On 2015-12-16 08:51 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Static analysis from clang scan-build detected a dead store
> to ptr1 which we can safely remove.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/acpi/dbg2/dbg2.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/src/acpi/dbg2/dbg2.c b/src/acpi/dbg2/dbg2.c
> index 3d12efc..7a234d6 100644
> --- a/src/acpi/dbg2/dbg2.c
> +++ b/src/acpi/dbg2/dbg2.c
> @@ -128,7 +128,6 @@ static void dbg2_obj_find(
>   	 *	     \_SB_.A___.BB__.CCC_.DDDD.EE__
>   	 */
>   	expanded = alloca(1 + (5 * (i + 1)));
> -	ptr1 = obj_name;
>   	ptr2 = expanded;
>
>   	for (i = -1, ptr1 = obj_name; ; ptr1++) {
>


Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu Dec. 16, 2015, 6:22 a.m. UTC | #2 
On 2015年12月16日 08:51, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Static analysis from clang scan-build detected a dead store
> to ptr1 which we can safely remove.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/acpi/dbg2/dbg2.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/src/acpi/dbg2/dbg2.c b/src/acpi/dbg2/dbg2.c
> index 3d12efc..7a234d6 100644
> --- a/src/acpi/dbg2/dbg2.c
> +++ b/src/acpi/dbg2/dbg2.c
> @@ -128,7 +128,6 @@ static void dbg2_obj_find(
>   	 *	     \_SB_.A___.BB__.CCC_.DDDD.EE__
>   	 */
>   	expanded = alloca(1 + (5 * (i + 1)));
> -	ptr1 = obj_name;
>   	ptr2 = expanded;
>
>   	for (i = -1, ptr1 = obj_name; ; ptr1++) {
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox

Patch

diff --git a/src/acpi/dbg2/dbg2.c b/src/acpi/dbg2/dbg2.c
index 3d12efc..7a234d6 100644
--- a/src/acpi/dbg2/dbg2.c
+++ b/src/acpi/dbg2/dbg2.c
@@ -128,7 +128,6 @@  static void dbg2_obj_find(
 	 *	     \_SB_.A___.BB__.CCC_.DDDD.EE__
 	 */
 	expanded = alloca(1 + (5 * (i + 1)));
-	ptr1 = obj_name;
 	ptr2 = expanded;
 
 	for (i = -1, ptr1 = obj_name; ; ptr1++) {