diff mbox

[net-next] net, cgroup: cgroup_sk_updat_lock was missing initializer

Message ID 20151214162406.GA4026@mtj.duckdns.org
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Tejun Heo Dec. 14, 2015, 4:24 p.m. UTC 
bd1060a1d671 ("sock, cgroup: add sock->sk_cgroup") added global
spinlock cgroup_sk_update_lock but erroneously skipped initializer
leading to uninitialized spinlock warning.  Fix it by using
DEFINE_SPINLOCK().

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Dexuan Cui <decui@microsoft.com>
Fixes: bd1060a1d671 ("sock, cgroup: add sock->sk_cgroup")
---
Hello, Dexuan.

Oops, sorry about that.  Somehow thought it was a different problem
which is already fixed.  This should do it.

Thanks.

 kernel/cgroup.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller Dec. 14, 2015, 7:20 p.m. UTC | #1 
From: Tejun Heo <tj@kernel.org>
Date: Mon, 14 Dec 2015 11:24:06 -0500

> bd1060a1d671 ("sock, cgroup: add sock->sk_cgroup") added global
> spinlock cgroup_sk_update_lock but erroneously skipped initializer
> leading to uninitialized spinlock warning.  Fix it by using
> DEFINE_SPINLOCK().
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Dexuan Cui <decui@microsoft.com>
> Fixes: bd1060a1d671 ("sock, cgroup: add sock->sk_cgroup")

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Dexuan Cui Dec. 15, 2015, 2:11 a.m. UTC | #2 
> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Tuesday, December 15, 2015 3:21
> To: tj@kernel.org
> Cc: Dexuan Cui <decui@microsoft.com>; pablo@netfilter.org; kaber@trash.net;
> kadlec@blackhole.kfki.hu; daniel@iogearbox.net; daniel.wagner@bmw-carit.de;
> nhorman@tuxdriver.com; lizefan@huawei.com; hannes@cmpxchg.org;
> netdev@vger.kernel.org; netfilter-devel@vger.kernel.org;
> coreteam@netfilter.org; cgroups@vger.kernel.org; linux-
> kernel@vger.kernel.org; kernel-team@fb.com; ninasc@fb.com
> Subject: Re: [PATCH net-next] net, cgroup: cgroup_sk_updat_lock was missing
> initializer
> 
> From: Tejun Heo <tj@kernel.org>
> Date: Mon, 14 Dec 2015 11:24:06 -0500
> 
> > bd1060a1d671 ("sock, cgroup: add sock->sk_cgroup") added global
> > spinlock cgroup_sk_update_lock but erroneously skipped initializer
> > leading to uninitialized spinlock warning.  Fix it by using
> > DEFINE_SPINLOCK().
> >
> > Signed-off-by: Tejun Heo <tj@kernel.org>
> > Reported-by: Dexuan Cui <decui@microsoft.com>
> > Fixes: bd1060a1d671 ("sock, cgroup: add sock->sk_cgroup")
> 
> Applied, thanks.

Thanks! I can confirm it fixed the issue.

Thanks,
-- Dexuan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 4f8f792..4466273f 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -5790,7 +5790,7 @@  EXPORT_SYMBOL_GPL(cgroup_get_from_path);
 
 #if defined(CONFIG_CGROUP_NET_PRIO) || defined(CONFIG_CGROUP_NET_CLASSID)
 
-spinlock_t cgroup_sk_update_lock;
+DEFINE_SPINLOCK(cgroup_sk_update_lock);
 static bool cgroup_sk_alloc_disabled __read_mostly;
 
 void cgroup_sk_alloc_disable(void)