| Message ID | 1450100437-19407-1-git-send-email-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
On 2015-12-14 09:40 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Forgot to check for fwts_iasl_init failure, add in a test abort > message if it fails. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/acpi/acpidump/acpidump.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/acpi/acpidump/acpidump.c b/src/acpi/acpidump/acpidump.c > index 765cf9f..d49b7a2 100644 > --- a/src/acpi/acpidump/acpidump.c > +++ b/src/acpi/acpidump/acpidump.c > @@ -110,7 +110,10 @@ static int acpidump_test1(fwts_framework *fw) > int i; > > fwts_infoonly(fw); > - fwts_iasl_init(fw); > + if (fwts_iasl_init(fw) != FWTS_OK) { > + fwts_aborted(fw, "Failure to initialise iasl, aborting."); > + return FWTS_ERROR; > + } > > for (i = 0; i < ACPI_MAX_TABLES; i++) { > fwts_acpi_table_info *table; > Acked-by: Alex Hung <alex.hung@canonical.com>
On 2015年12月14日 21:40, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Forgot to check for fwts_iasl_init failure, add in a test abort > message if it fails. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/acpi/acpidump/acpidump.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/acpi/acpidump/acpidump.c b/src/acpi/acpidump/acpidump.c > index 765cf9f..d49b7a2 100644 > --- a/src/acpi/acpidump/acpidump.c > +++ b/src/acpi/acpidump/acpidump.c > @@ -110,7 +110,10 @@ static int acpidump_test1(fwts_framework *fw) > int i; > > fwts_infoonly(fw); > - fwts_iasl_init(fw); > + if (fwts_iasl_init(fw) != FWTS_OK) { > + fwts_aborted(fw, "Failure to initialise iasl, aborting."); > + return FWTS_ERROR; > + } > > for (i = 0; i < ACPI_MAX_TABLES; i++) { > fwts_acpi_table_info *table; > Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff --git a/src/acpi/acpidump/acpidump.c b/src/acpi/acpidump/acpidump.c index 765cf9f..d49b7a2 100644 --- a/src/acpi/acpidump/acpidump.c +++ b/src/acpi/acpidump/acpidump.c @@ -110,7 +110,10 @@ static int acpidump_test1(fwts_framework *fw) int i; fwts_infoonly(fw); - fwts_iasl_init(fw); + if (fwts_iasl_init(fw) != FWTS_OK) { + fwts_aborted(fw, "Failure to initialise iasl, aborting."); + return FWTS_ERROR; + } for (i = 0; i < ACPI_MAX_TABLES; i++) { fwts_acpi_table_info *table;