Patchwork pci hotplug: staticfy pci_device_hot_remove().

login
register
mail settings
Submitter Isaku Yamahata
Date June 15, 2010, 3:48 a.m.
Message ID <20100615034836.GU23473@valinux.co.jp>
Download mbox | patch
Permalink /patch/55603/
State New
Headers show

Comments

Isaku Yamahata - June 15, 2010, 3:48 a.m.
staticfy pci_device_hot_remove().

Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
 hw/pci-hotplug.c |    2 +-
 sysemu.h         |    1 -
 2 files changed, 1 insertions(+), 2 deletions(-)
Gerd Hoffmann - June 15, 2010, 8:58 a.m.
On 06/15/10 05:48, Isaku Yamahata wrote:
> staticfy pci_device_hot_remove().

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

cheers,
   Gerd
Isaku Yamahata - June 21, 2010, 9:54 a.m.
Ping.
Michael, do you have any comment on this?

On Tue, Jun 15, 2010 at 12:48:36PM +0900, Isaku Yamahata wrote:
> staticfy pci_device_hot_remove().
> 
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> ---
>  hw/pci-hotplug.c |    2 +-
>  sysemu.h         |    1 -
>  2 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/pci-hotplug.c b/hw/pci-hotplug.c
> index c39e640..098264c 100644
> --- a/hw/pci-hotplug.c
> +++ b/hw/pci-hotplug.c
> @@ -258,7 +258,7 @@ void pci_device_hot_add(Monitor *mon, const QDict *qdict)
>  }
>  #endif
>  
> -int pci_device_hot_remove(Monitor *mon, const char *pci_addr)
> +static int pci_device_hot_remove(Monitor *mon, const char *pci_addr)
>  {
>      PCIDevice *d;
>      int dom, bus;
> diff --git a/sysemu.h b/sysemu.h
> index c758243..9c988bb 100644
> --- a/sysemu.h
> +++ b/sysemu.h
> @@ -149,7 +149,6 @@ extern unsigned int nb_prom_envs;
>  /* pci-hotplug */
>  void pci_device_hot_add(Monitor *mon, const QDict *qdict);
>  void drive_hot_add(Monitor *mon, const QDict *qdict);
> -int pci_device_hot_remove(Monitor *mon, const char *pci_addr);
>  void do_pci_device_hot_remove(Monitor *mon, const QDict *qdict);
>  
>  /* serial ports */
> -- 
> 1.6.6.1
> 
>
Michael S. Tsirkin - June 21, 2010, 11:37 a.m.
On Tue, Jun 15, 2010 at 12:48:36PM +0900, Isaku Yamahata wrote:
> staticfy pci_device_hot_remove().
> 
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

Applied, thanks.

> ---
>  hw/pci-hotplug.c |    2 +-
>  sysemu.h         |    1 -
>  2 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/pci-hotplug.c b/hw/pci-hotplug.c
> index c39e640..098264c 100644
> --- a/hw/pci-hotplug.c
> +++ b/hw/pci-hotplug.c
> @@ -258,7 +258,7 @@ void pci_device_hot_add(Monitor *mon, const QDict *qdict)
>  }
>  #endif
>  
> -int pci_device_hot_remove(Monitor *mon, const char *pci_addr)
> +static int pci_device_hot_remove(Monitor *mon, const char *pci_addr)
>  {
>      PCIDevice *d;
>      int dom, bus;
> diff --git a/sysemu.h b/sysemu.h
> index c758243..9c988bb 100644
> --- a/sysemu.h
> +++ b/sysemu.h
> @@ -149,7 +149,6 @@ extern unsigned int nb_prom_envs;
>  /* pci-hotplug */
>  void pci_device_hot_add(Monitor *mon, const QDict *qdict);
>  void drive_hot_add(Monitor *mon, const QDict *qdict);
> -int pci_device_hot_remove(Monitor *mon, const char *pci_addr);
>  void do_pci_device_hot_remove(Monitor *mon, const QDict *qdict);
>  
>  /* serial ports */
> -- 
> 1.6.6.1

Patch

diff --git a/hw/pci-hotplug.c b/hw/pci-hotplug.c
index c39e640..098264c 100644
--- a/hw/pci-hotplug.c
+++ b/hw/pci-hotplug.c
@@ -258,7 +258,7 @@  void pci_device_hot_add(Monitor *mon, const QDict *qdict)
 }
 #endif
 
-int pci_device_hot_remove(Monitor *mon, const char *pci_addr)
+static int pci_device_hot_remove(Monitor *mon, const char *pci_addr)
 {
     PCIDevice *d;
     int dom, bus;
diff --git a/sysemu.h b/sysemu.h
index c758243..9c988bb 100644
--- a/sysemu.h
+++ b/sysemu.h
@@ -149,7 +149,6 @@  extern unsigned int nb_prom_envs;
 /* pci-hotplug */
 void pci_device_hot_add(Monitor *mon, const QDict *qdict);
 void drive_hot_add(Monitor *mon, const QDict *qdict);
-int pci_device_hot_remove(Monitor *mon, const char *pci_addr);
 void do_pci_device_hot_remove(Monitor *mon, const QDict *qdict);
 
 /* serial ports */