Patchwork xen: Fix build error due to missing include

login
register
mail settings
Submitter Jan Kiszka
Date June 14, 2010, 9:11 p.m.
Message ID <4C169AE9.8070404@web.de>
Download mbox | patch
Permalink /patch/55591/
State New
Headers show

Comments

Jan Kiszka - June 14, 2010, 9:11 p.m.
From: Jan Kiszka <jan.kiszka@siemens.com>

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 hw/xen_backend.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Markus Armbruster - June 15, 2010, 8:57 a.m.
Jan Kiszka <jan.kiszka@web.de> writes:

> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  hw/xen_backend.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/xen_backend.h b/hw/xen_backend.h
> index f07f7d4..cc25f9d 100644
> --- a/hw/xen_backend.h
> +++ b/hw/xen_backend.h
> @@ -5,6 +5,7 @@
>  #include "sysemu.h"
>  #include "net.h"
>  #include "block_int.h"
> +#include "blockdev.h"
>  
>  /* ------------------------------------------------------------- */

My bad.  Thanks for fixing this!  By the way, Is "block_int.h" really
needed here?
Kevin Wolf - June 15, 2010, 9 a.m.
Am 14.06.2010 23:11, schrieb Jan Kiszka:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

Thanks, applied to the block branch.

Kevin
Jan Kiszka - June 15, 2010, 9:02 a.m.
Markus Armbruster wrote:
> Jan Kiszka <jan.kiszka@web.de> writes:
> 
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  hw/xen_backend.h |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/xen_backend.h b/hw/xen_backend.h
>> index f07f7d4..cc25f9d 100644
>> --- a/hw/xen_backend.h
>> +++ b/hw/xen_backend.h
>> @@ -5,6 +5,7 @@
>>  #include "sysemu.h"
>>  #include "net.h"
>>  #include "block_int.h"
>> +#include "blockdev.h"
>>  
>>  /* ------------------------------------------------------------- */
> 
> My bad.  Thanks for fixing this!  By the way, Is "block_int.h" really
> needed here?

Something else broke when I removed it, haven't looked at details though.

Jan
Markus Armbruster - June 15, 2010, 9:26 a.m.
Jan Kiszka <jan.kiszka@siemens.com> writes:

> Markus Armbruster wrote:
>> Jan Kiszka <jan.kiszka@web.de> writes:
>> 
>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>> ---
>>>  hw/xen_backend.h |    1 +
>>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/hw/xen_backend.h b/hw/xen_backend.h
>>> index f07f7d4..cc25f9d 100644
>>> --- a/hw/xen_backend.h
>>> +++ b/hw/xen_backend.h
>>> @@ -5,6 +5,7 @@
>>>  #include "sysemu.h"
>>>  #include "net.h"
>>>  #include "block_int.h"
>>> +#include "blockdev.h"
>>>  
>>>  /* ------------------------------------------------------------- */
>> 
>> My bad.  Thanks for fixing this!  By the way, Is "block_int.h" really
>> needed here?
>
> Something else broke when I removed it, haven't looked at details though.

Just wondering because exposing block internals in another header file
is *not* nice.

Patch

diff --git a/hw/xen_backend.h b/hw/xen_backend.h
index f07f7d4..cc25f9d 100644
--- a/hw/xen_backend.h
+++ b/hw/xen_backend.h
@@ -5,6 +5,7 @@ 
 #include "sysemu.h"
 #include "net.h"
 #include "block_int.h"
+#include "blockdev.h"
 
 /* ------------------------------------------------------------- */